-
-
Notifications
You must be signed in to change notification settings - Fork 801
Adding support for protocol handler #3870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marcellintacite
wants to merge
17
commits into
conversejs:master
Choose a base branch
from
marcellintacite:add-protocol-handler
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adding support for protocol handler #3870
marcellintacite
wants to merge
17
commits into
conversejs:master
from
marcellintacite:add-protocol-handler
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcbrand
reviewed
Oct 1, 2025
jcbrand
reviewed
Oct 1, 2025
jcbrand
reviewed
Oct 6, 2025
28e327a to
5b41936
Compare
Member
|
Looking good so far @marcellintacite! Please also remember to update the DOAP file to mention support for the new XEP |
jcbrand
reviewed
Oct 7, 2025
Co-authored-by: JC Brand <jc@opkode.com>
Co-authored-by: JC Brand <jc@opkode.com>
Co-authored-by: JC Brand <jc@opkode.com>
jcbrand
reviewed
Oct 9, 2025
Co-authored-by: JC Brand <jc@opkode.com>
jcbrand
reviewed
Oct 13, 2025
Contributor
Author
|
@jcbrand Hello, i would like your review for the test i wrote |
jcbrand
requested changes
Oct 15, 2025
Co-authored-by: JC Brand <jc@opkode.com>
Contributor
Author
|
@jcbrand i need your help on tests so i can get done with this PR. I am facing some errors |
67fa8c7 to
cd88326
Compare
Contributor
Author
|
Hello @jcbrand i have fixed test issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a draft for this issue : #1247
This merge request adds support for handling xmpp: protocol links in Converse.js, allowing users to click links like xmpp:user@example.com to automatically open a chat with the specified JID if logged in. This enhances user experience by enabling seamless integration with external XMPP links (e.g., from emails, websites, or other apps).
Before submitting your request, please make sure the following conditions are met:
CHANGES.mddocument it in
docs/source/configuration.rstwith
make checkor you can run them in the browser by runningmake serveand then opening
http://localhost:8000/tests.html.