fix(kiali): Tool names with prefix kiali_ #471
Conversation
aljesusg
changed the title
|
cc @manusa |
| - The server uses your existing Kubernetes credentials (from kubeconfig or in-cluster) to set a bearer token for Kiali calls. | ||
| - If you pass an HTTP Authorization header to the MCP HTTP endpoint, that is not required for Kiali; Kiali calls use the server's configured token. | ||
|
|
||
| ### Available tools (initial) |
There was a problem hiding this comment.
@aljesusg is there a reason for getting rid of all the tool docs here?
If we want to de-duplicate the tool docs, maybe we can link to the section of the README which describes these tools from this file?
There was a problem hiding this comment.
I was actually going to try that :) I wasn't aware Alberto had removed the docs already.
Let me take care of adding the link in a different PR, I want to see if I can create a tags with names that can be linked and expand the collapsed section or at least point the user exactly to the collapsed section summary
There was a problem hiding this comment.
There are some duplicates in the README, so I can update the documentation script for the rest of the tools if you want and keep the methods here.
It makes more sense to include a link from the README to the toolset documentation instead of duplicating the information.
There was a problem hiding this comment.
I did some changes in docs for toolsets out the "core"
aljesusg
force-pushed
the
issue_467
branch
5 times, most recently
from
bf2ebbe to
7887148
Compare
|
docs/KIALI.md
Outdated
| toolsets = ["core", "kiali"] | ||
|
|
||
| [toolset_configs.kiali] | ||
| url = "https://kiali.example" |
There was a problem hiding this comment.
@aljesusg maybe it is because I haven't used Kiali much but it's not clear to me from the docs here what value should go in this url/how I would find it.
Would you mind adding a sentence somewhere about what this value should be?
There was a problem hiding this comment.
Of course. It’s the endpoint/route to Kiali; I’ll add a comment. I’ll also try to implement autodiscovery for this downstream.
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
* fix(kiali): Tool names with prefix kiali_ Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com> * Change links Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com> * Add comment to the url configuration Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com> --------- Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com> Signed-off-by: Muhammad Faizan <mfaizan.se@gmail.com>
3 participants
Fix #467
Add prefix kiali_ to all tools related with Kiali