Skip to content

Conversation

@compnerd
Copy link
Owner

@compnerd compnerd commented Nov 6, 2025

This is now a required component of the installer image and built with CMake. This completes the toolchain coverage.

@compnerd compnerd requested review from Steelskin and Copilot November 6, 2025 06:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates swift-docc and its dependencies into the GitHub Actions workflow for building the Swift toolchain. The changes add the required build steps for swift-docc, swift-docc-symbolkit, and swift-docc-render-artifact as part of the toolchain installer image.

  • Adds three new required input parameters for swift-docc component revisions
  • Integrates checkout and build steps for swift-docc components in the toolchain workflow
  • Passes swift-docc-render-artifact path to the MSBuild installer configuration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/swift-toolchain.yml Adds input parameters, checkout steps, CMake configuration/build steps for swift-docc components, and installer configuration parameter
.github/workflows/build-toolchain.yml Passes through the new swift-docc revision parameters from context to workflow calls

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

arch: ${{ matrix.arch }}
src-dir: ${{ github.workspace }}/SourceCache/swift-docc-symbolkit
bin-dir: ${{ github.workspace }}/BinaryCache/swift-docc-symbolkit
install-dir: ${{ github.workspace }}/BuildRoot/Library/Developer/Toolchains/${{ input.swift_version }}+Asserts/usr
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable reference is missing 's' - should be inputs.swift_version instead of input.swift_version.

Suggested change
install-dir: ${{ github.workspace }}/BuildRoot/Library/Developer/Toolchains/${{ input.swift_version }}+Asserts/usr
install-dir: ${{ github.workspace }}/BuildRoot/Library/Developer/Toolchains/${{ inputs.swift_version }}+Asserts/usr

Copilot uses AI. Check for mistakes.
arch: ${{ matrix.arch }}
src-dir: ${{ github.workspace }}/SourceCache/swift-docc
bin-dir: ${{ github.workspace }}/BinaryCache/swift-docc
install-dir: ${{ github.workspace }}/BuildRoot/Library/Developer/Toolchains/${{ input.swift_version }}+Asserts/usr
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable reference is missing 's' - should be inputs.swift_version instead of input.swift_version.

Suggested change
install-dir: ${{ github.workspace }}/BuildRoot/Library/Developer/Toolchains/${{ input.swift_version }}+Asserts/usr
install-dir: ${{ github.workspace }}/BuildRoot/Library/Developer/Toolchains/${{ inputs.swift_version }}+Asserts/usr

Copilot uses AI. Check for mistakes.
-p:SignOutput=${{ inputs.signed }} `
-p:CERTIFICATE=${env:CERTIFICATE} `
-p:PASSPHRASE=${{ secrets.PASSPHRASE }} `
-p:SWIFT_DOCC_RENDER_ARTIFACT_ROOT = "${{ github.workspace }}\SourceCache\swift-docc-render-artifact" `
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSBuild parameter assignment has spaces around the equals sign which will cause a syntax error. Should be -p:SWIFT_DOCC_RENDER_ARTIFACT_ROOT=\"${{ github.workspace }}\SourceCache\swift-docc-render-artifact\" without spaces around =.

Suggested change
-p:SWIFT_DOCC_RENDER_ARTIFACT_ROOT = "${{ github.workspace }}\SourceCache\swift-docc-render-artifact" `
-p:SWIFT_DOCC_RENDER_ARTIFACT_ROOT="${{ github.workspace }}\SourceCache\swift-docc-render-artifact" `

Copilot uses AI. Check for mistakes.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

This is now a required component of the installer image and built with
CMake. This completes the toolchain coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants