-
Notifications
You must be signed in to change notification settings - Fork 57
GHA: wire up build of swift-docc #1052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR integrates swift-docc and its dependencies into the GitHub Actions workflow for building the Swift toolchain. The changes add the required build steps for swift-docc, swift-docc-symbolkit, and swift-docc-render-artifact as part of the toolchain installer image.
- Adds three new required input parameters for swift-docc component revisions
- Integrates checkout and build steps for swift-docc components in the toolchain workflow
- Passes swift-docc-render-artifact path to the MSBuild installer configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/swift-toolchain.yml | Adds input parameters, checkout steps, CMake configuration/build steps for swift-docc components, and installer configuration parameter |
| .github/workflows/build-toolchain.yml | Passes through the new swift-docc revision parameters from context to workflow calls |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| arch: ${{ matrix.arch }} | ||
| src-dir: ${{ github.workspace }}/SourceCache/swift-docc-symbolkit | ||
| bin-dir: ${{ github.workspace }}/BinaryCache/swift-docc-symbolkit | ||
| install-dir: ${{ github.workspace }}/BuildRoot/Library/Developer/Toolchains/${{ input.swift_version }}+Asserts/usr |
Copilot
AI
Nov 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable reference is missing 's' - should be inputs.swift_version instead of input.swift_version.
| install-dir: ${{ github.workspace }}/BuildRoot/Library/Developer/Toolchains/${{ input.swift_version }}+Asserts/usr | |
| install-dir: ${{ github.workspace }}/BuildRoot/Library/Developer/Toolchains/${{ inputs.swift_version }}+Asserts/usr |
| arch: ${{ matrix.arch }} | ||
| src-dir: ${{ github.workspace }}/SourceCache/swift-docc | ||
| bin-dir: ${{ github.workspace }}/BinaryCache/swift-docc | ||
| install-dir: ${{ github.workspace }}/BuildRoot/Library/Developer/Toolchains/${{ input.swift_version }}+Asserts/usr |
Copilot
AI
Nov 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable reference is missing 's' - should be inputs.swift_version instead of input.swift_version.
| install-dir: ${{ github.workspace }}/BuildRoot/Library/Developer/Toolchains/${{ input.swift_version }}+Asserts/usr | |
| install-dir: ${{ github.workspace }}/BuildRoot/Library/Developer/Toolchains/${{ inputs.swift_version }}+Asserts/usr |
| -p:SignOutput=${{ inputs.signed }} ` | ||
| -p:CERTIFICATE=${env:CERTIFICATE} ` | ||
| -p:PASSPHRASE=${{ secrets.PASSPHRASE }} ` | ||
| -p:SWIFT_DOCC_RENDER_ARTIFACT_ROOT = "${{ github.workspace }}\SourceCache\swift-docc-render-artifact" ` |
Copilot
AI
Nov 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MSBuild parameter assignment has spaces around the equals sign which will cause a syntax error. Should be -p:SWIFT_DOCC_RENDER_ARTIFACT_ROOT=\"${{ github.workspace }}\SourceCache\swift-docc-render-artifact\" without spaces around =.
| -p:SWIFT_DOCC_RENDER_ARTIFACT_ROOT = "${{ github.workspace }}\SourceCache\swift-docc-render-artifact" ` | |
| -p:SWIFT_DOCC_RENDER_ARTIFACT_ROOT="${{ github.workspace }}\SourceCache\swift-docc-render-artifact" ` |
141ed25 to
804dc68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
804dc68 to
284fba0
Compare
This is now a required component of the installer image and built with CMake. This completes the toolchain coverage.
284fba0 to
ea529b1
Compare
This is now a required component of the installer image and built with CMake. This completes the toolchain coverage.