Skip to content

Conversation

@Lee-W
Copy link
Member

@Lee-W Lee-W commented Nov 8, 2025

Description

https://docs.astral.sh/ruff/rules/assert/#assert-s101

  • style(ruff): enable S101 check to avoid assert usage in production code
  • build(tox): add 3.14 support
  • build: update dev dependencies

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly
  • Check and fix any broken links (internal or external) in the documentation

When running poetry doc, any broken internal documentation links will be reported in the console output like this:

INFO    -  Doc file 'config.md' contains a link 'commands/bump.md#-post_bump_hooks', but the doc 'commands/bump.md' does not contain an anchor '#-post_bump_hooks'.

Expected Behavior

Steps to Test This Pull Request

Additional Context

@Lee-W Lee-W added this to the 4.10.1 milestone Nov 8, 2025
@codecov
Copy link

codecov bot commented Nov 8, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (v4-10-1@d389330). Learn more about missing BASE report.

Files with missing lines Patch % Lines
commitizen/commands/changelog.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             v4-10-1    #1642   +/-   ##
==========================================
  Coverage           ?   98.21%           
==========================================
  Files              ?       58           
  Lines              ?     2695           
  Branches           ?        0           
==========================================
  Hits               ?     2647           
  Misses             ?       48           
  Partials           ?        0           
Flag Coverage Δ
unittests 98.21% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism
Copy link
Contributor

LGTM. I didn't know assert is bad. Thanks

@Lee-W
Copy link
Member Author

Lee-W commented Nov 13, 2025

LGTM. I didn't know assert is bad. Thanks

IIRC, there's a security issue related to this

@Lee-W Lee-W changed the base branch from master to v4-10-1 November 13, 2025 01:27
@Lee-W Lee-W merged commit 21ad289 into v4-10-1 Nov 13, 2025
17 of 18 checks passed
@Lee-W Lee-W deleted the enable-ruff-S101 branch November 13, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants