[CM-1580]: Implemented test case to check synchronous implementation.

Author: yaricom

comet-java-client/src/test/java/ml/comet/experiment/impl/ApiExperimentTest.java

@@ -6,6 +6,7 @@
 import ml.comet.experiment.context.ExperimentContext;
 import ml.comet.experiment.exception.CometGeneralException;
 import ml.comet.experiment.impl.asset.LoggedExperimentAssetImpl;
+import ml.comet.experiment.model.Curve;
 import org.apache.commons.lang3.StringUtils;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Tag;
@@ -20,6 +21,9 @@
 import static ml.comet.experiment.impl.ExperimentTestFactory.WORKSPACE_NAME;
 import static ml.comet.experiment.impl.ExperimentTestFactory.createApiExperiment;
 import static ml.comet.experiment.impl.ExperimentTestFactory.createOnlineExperiment;
+import static ml.comet.experiment.impl.TestUtils.SOME_FULL_CONTEXT;
+import static ml.comet.experiment.impl.TestUtils.createCurve;
+import static ml.comet.experiment.impl.asset.AssetType.CURVE;
 import static ml.comet.experiment.impl.asset.AssetType.TEXT_SAMPLE;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
@@ -102,4 +106,52 @@ public void testLogTextShort() throws Exception {
             assertTrue(StringUtils.isBlank(assetContext.getContext()), "no context ID expected");
         }
     }
+
+    @Test
+    public void testLogCurve() throws Exception {
+        try (ApiExperiment apiExperiment = createApiExperiment()) {
+            String fileName = "someCurve";
+            Curve curve = createCurve(fileName, 10);
+            apiExperiment.logCurve(curve, true, SOME_FULL_CONTEXT);
+
+            // check that CURVE asset was saved as expected
+            List<LoggedExperimentAsset> assets = apiExperiment.getAssetList(CURVE.type());
+            assertEquals(1, assets.size(), "wrong number of assets returned");
+
+            LoggedExperimentAsset asset = assets.get(0);
+            assertEquals(CURVE.type(), asset.getType(), "wrong asset type");
+            assertEquals(0, asset.getMetadata().size(), "no metadata expected");
+            ExperimentContext assetContext = ((LoggedExperimentAssetImpl) asset).getContext();
+            assertEquals(SOME_FULL_CONTEXT.getStep(), assetContext.getStep(), "wrong context step");
+            assertEquals(SOME_FULL_CONTEXT.getContext(), assetContext.getContext(), "wrong context ID");
+        }
+    }
+
+    @Test
+    public void testLogCurveOverwrite() throws Exception {
+        try (ApiExperiment apiExperiment = createApiExperiment()) {
+            String fileName = "someCurve";
+            int pointsCount = 10;
+            Curve curve = createCurve(fileName, pointsCount);
+            apiExperiment.logCurve(curve, false, SOME_FULL_CONTEXT);
+
+            // check that CURVE asset was saved as expected
+            List<LoggedExperimentAsset> assets = apiExperiment.getAssetList(CURVE.type());
+            assertEquals(1, assets.size(), "wrong number of assets returned");
+
+            long size = assets.get(0).getSize().orElse((long) -1);
+            assertTrue(size > 0, "wrong asset size");
+
+            // overwrite created curve with bigger ones
+            //
+            curve = createCurve(fileName, pointsCount * 2);
+            apiExperiment.logCurve(curve, true, SOME_FULL_CONTEXT);
+
+            assets = apiExperiment.getAssetList(CURVE.type());
+            assertEquals(1, assets.size(), "wrong number of assets returned");
+
+            long newSize = assets.get(0).getSize().orElse((long) -1);
+            assertTrue(newSize > size);
+        }
+    }
 }

comet-java-client/src/test/java/ml/comet/experiment/impl/TestUtils.java

@@ -1,6 +1,8 @@
 package ml.comet.experiment.impl;
 
 import ml.comet.experiment.context.ExperimentContext;
+import ml.comet.experiment.model.Curve;
+import ml.comet.experiment.model.DataPoint;
 import org.awaitility.Awaitility;
 
 import java.io.File;
@@ -67,4 +69,12 @@ public static void awaitForCondition(BooleanSupplier booleanSupplier, String con
                 .pollInterval(300L, MILLISECONDS)
                 .until(booleanSupplier::getAsBoolean);
     }
+
+    public static Curve createCurve(String name, int pointsCount) {
+        DataPoint[] dataPoints = new DataPoint[pointsCount];
+        for (int i = 0; i < pointsCount; i++) {
+            dataPoints[i] = DataPoint.of(i, i * 10);
+        }
+        return new Curve(dataPoints, name);
+    }
 }

comet-java-client/src/test/java/ml/comet/experiment/impl/utils/AssetUtilsTest.java

@@ -6,7 +6,6 @@
 import ml.comet.experiment.impl.asset.AssetImpl;
 import ml.comet.experiment.impl.asset.AssetType;
 import ml.comet.experiment.model.Curve;
-import ml.comet.experiment.model.DataPoint;
 import org.apache.commons.io.FilenameUtils;
 import org.apache.commons.io.file.PathUtils;
 import org.apache.commons.lang3.StringUtils;
@@ -35,6 +34,7 @@
 
 import static java.util.Optional.empty;
 import static java.util.Optional.ofNullable;
+import static ml.comet.experiment.impl.TestUtils.createCurve;
 import static ml.comet.experiment.impl.asset.AssetType.ASSET;
 import static ml.comet.experiment.impl.asset.AssetType.CURVE;
 import static ml.comet.experiment.impl.asset.AssetType.NOTEBOOK;
@@ -223,14 +223,9 @@ public void testCreateAssetFromData() {
     @Test
     public void testCreateAssetFromCurve() {
         String json = "{\"name\":\"someCurve\",\"x\":[0.0,1.0,2.0,3.0,4.0,5.0,6.0,7.0,8.0,9.0],\"y\":[0.0,10.0,20.0,30.0,40.0,50.0,60.0,70.0,80.0,90.0]}";
-        byte []data = json.getBytes(StandardCharsets.UTF_8);
-        int count = 10;
-        DataPoint[] dataPoints = new DataPoint[count];
-        for (int i = 0; i < count; i++) {
-            dataPoints[i] = DataPoint.of(i, i * 10);
-        }
+        byte[] data = json.getBytes(StandardCharsets.UTF_8);
         String fileName = "someCurve";
-        Curve curve = new Curve(dataPoints, fileName);
+        Curve curve = createCurve(fileName, 10);
 
         AssetImpl asset = createAssetFromCurve(curve, true);
         assertNotNull(asset);