Skip to content

Commit 879428f

Browse files
committed
[CM-1580]: Created synchronous implementation of defined methods.
1 parent be9486f commit 879428f

File tree

2 files changed

+25
-4
lines changed

2 files changed

+25
-4
lines changed

comet-java-client/src/main/java/ml/comet/experiment/impl/BaseExperiment.java

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
import ml.comet.experiment.impl.utils.ExceptionUtils;
4242
import ml.comet.experiment.impl.utils.FileUtils;
4343
import ml.comet.experiment.impl.utils.SystemUtils;
44+
import ml.comet.experiment.model.Curve;
4445
import ml.comet.experiment.model.ExperimentMetadata;
4546
import ml.comet.experiment.model.GitMetaData;
4647
import ml.comet.experiment.model.Value;
@@ -95,6 +96,7 @@
9596
import static ml.comet.experiment.impl.resources.LogMessages.GET_ARTIFACT_FAILED_UNEXPECTEDLY;
9697
import static ml.comet.experiment.impl.resources.LogMessages.REMOTE_ASSET_CANNOT_BE_DOWNLOADED;
9798
import static ml.comet.experiment.impl.resources.LogMessages.getString;
99+
import static ml.comet.experiment.impl.utils.AssetUtils.createAssetFromCurve;
98100
import static ml.comet.experiment.impl.utils.AssetUtils.createAssetFromData;
99101
import static ml.comet.experiment.impl.utils.AssetUtils.createAssetFromFile;
100102
import static ml.comet.experiment.impl.utils.RestApiUtils.createArtifactUpsertRequest;
@@ -450,7 +452,7 @@ public void logCode(File file) {
450452
}
451453

452454
@Override
453-
public void logText(String text, ExperimentContext context, Map<String, Object> metadata) {
455+
public void logText(@NonNull String text, @NonNull ExperimentContext context, Map<String, Object> metadata) {
454456
if (getLogger().isDebugEnabled()) {
455457
getLogger().debug("logging text {} with context {}", text, context);
456458
}
@@ -461,7 +463,7 @@ public void logText(String text, ExperimentContext context, Map<String, Object>
461463
}
462464

463465
@Override
464-
public void logText(String text, ExperimentContext context) {
466+
public void logText(String text, @NonNull ExperimentContext context) {
465467
this.logText(text, context, null);
466468
}
467469

@@ -470,6 +472,25 @@ public void logText(String text) {
470472
this.logText(text, ExperimentContext.empty());
471473
}
472474

475+
@Override
476+
public void logCurve(@NonNull Curve curve, boolean overwrite, @NonNull ExperimentContext context) {
477+
if (getLogger().isDebugEnabled()) {
478+
getLogger().debug("logging curve {} with context {}", curve, context);
479+
}
480+
AssetImpl asset = createAssetFromCurve(curve, overwrite);
481+
this.logAsset(asset, context);
482+
}
483+
484+
@Override
485+
public void logCurve(@NonNull Curve curve, boolean overwrite) {
486+
this.logCurve(curve, overwrite, ExperimentContext.empty());
487+
}
488+
489+
@Override
490+
public void logCurve(@NonNull Curve curve) {
491+
this.logCurve(curve, false);
492+
}
493+
473494
@Override
474495
public void uploadAsset(@NonNull File file, @NonNull String logicalPath,
475496
boolean overwrite, @NonNull ExperimentContext context) {

comet-java-client/src/main/java/ml/comet/experiment/impl/OnlineExperimentImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,7 @@ public void logCode(@NonNull File file) {
466466
}
467467

468468
@Override
469-
public void logText(String text, ExperimentContext context, Map<String, Object> metadata) {
469+
public void logText(@NonNull String text, @NonNull ExperimentContext context, Map<String, Object> metadata) {
470470
this.executeLogAction(() ->
471471
this.logAssetDataAsync(
472472
text.getBytes(StandardCharsets.UTF_8), AUTOGENERATED_LOGICAL_PATH_HOLDER,
@@ -476,7 +476,7 @@ public void logText(String text, ExperimentContext context, Map<String, Object>
476476
}
477477

478478
@Override
479-
public void logText(String text, ExperimentContext context) {
479+
public void logText(String text, @NonNull ExperimentContext context) {
480480
this.logText(text, context, null);
481481
}
482482

0 commit comments

Comments
 (0)