Skip to content

feat: implement runtime config loading for frontend #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 29, 2025
Merged

feat: implement runtime config loading for frontend #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6c5b0ed
fix: update AuthGate to use environment variable for Coder URL
atyrode Apr 29, 2025
d37634c
refactor: enhance Vite configuration to load environment variables
atyrode Apr 29, 2025
8aac360
fix: update AuthGate to use corrected environment variable for Coder URL
atyrode Apr 29, 2025
0a05951
Merge branch 'main' into authgate-hardcoded-fix
atyrode Apr 29, 2025
0bb5ac9
refactor: update Dockerfile and add startup script for application in…
atyrode Apr 29, 2025
904a735
refactor: update runtime configuration file location and script refer…
atyrode Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,9 @@ ENV PYTHONUNBUFFERED=1
# Document the port number the container will expose
EXPOSE 8000

# Run the application
CMD ["uvicorn", "main:app", "--host", "0.0.0.0", "--port", "8000"]
# Copy startup script
COPY scripts/startup.sh /app/
RUN chmod +x /app/startup.sh

# Run the startup script
CMD ["/app/startup.sh"]
13 changes: 13 additions & 0 deletions scripts/startup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
#!/bin/bash
set -e

# Create runtime config with environment variables
mkdir -p /app/frontend/dist/assets
cat > /app/frontend/dist/assets/runtime-config.js <<EOL
window.RUNTIME_CONFIG = {
CODER_URL: "${CODER_URL}"
};
EOL

# Start the application
exec uvicorn main:app --host 0.0.0.0 --port 8000
1 change: 1 addition & 0 deletions src/frontend/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

<title>Pad.ws</title>
<link rel="icon" type="image/x-icon" href="/assets/images/favicon.png" />
<script src="/assets/runtime-config.js"></script>
</head>

<body>
Expand Down
3 changes: 2 additions & 1 deletion src/frontend/src/AuthGate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ export default function AuthGate({ children }: { children: React.ReactNode }) {
if (isAuthenticated === true && !coderAuthDone) {
const iframe = document.createElement("iframe");
iframe.style.display = "none";
const coderUrl = import.meta.env.CODER_URL;
// Use runtime config if available, fall back to import.meta.env
const coderUrl = window.RUNTIME_CONFIG?.CODER_URL || import.meta.env.CODER_URL;
iframe.src = `${coderUrl}/api/v2/users/oidc/callback`;
console.debug(`[pad.ws] (Silently) Priming Coder OIDC session for ${coderUrl}`);

Expand Down
6 changes: 6 additions & 0 deletions src/frontend/src/global.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
interface Window {
RUNTIME_CONFIG?: {
CODER_URL: string;
};
ExcalidrawLib: any;
}