Skip to content

encoding='utf-8' correction #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

encoding='utf-8' correction #61

wants to merge 7 commits into from

Conversation

@phamhung075
Copy link

@phamhung075 phamhung075 commented Dec 27, 2024 •
edited
Loading

fix problem:
Error: 'charmap' codec can't encode characters in position 22-24: character maps to <undefined> Aborted!

result

PS D:\DaiHung\__temp\gitingest> gitingest "./../AIanalist/src/"
Analysis complete! Output written to: D:\DaiHung\__temp\gitingest\digest.txt

Summary:
Repository: AIanalist/src
Files analyzed: 97

Estimated tokens: 68.2k

cyclotruc
cyclotruc requested changes Dec 28, 2024
View reviewed changes
Copy link
Member

@cyclotruc cyclotruc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the correction, I just want to clarify a few details (and remove the digest.txt) before merging

src/gitingest/encoding.py
Copy link
Member

@cyclotruc cyclotruc Dec 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused why this function is defined here and in ingest.py as well

src/gitingest/cli.py Outdated
setup_encoding()

# Define constants
MAX_FILE_SIZE = 51200 # 50KB by default
Copy link
Member

@cyclotruc cyclotruc Dec 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the way Constants are handled right now is messy, not your fault but I'll try to figure out a cleaner way than having constants defined at the top of various files

@phamhung075
Copy link
Author

phamhung075 commented Dec 29, 2024 •
edited
Loading

i have this code change to #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cyclotruc cyclotruc cyclotruc requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phamhung075 @cyclotruc