-
Notifications
You must be signed in to change notification settings - Fork 81
feat(module/coder-labs/amp): add mode flag and disable animation #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
35C4n0r
wants to merge
13
commits into
coder:main
Choose a base branch
from
35C4n0r:fix-amp-module-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+30
−12
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
33e522e
feat: add mode flag and fix animation
35C4n0r 0fc6e5a
chore: validation fix
35C4n0r 1f139c5
wip
35C4n0r 0163620
Merge branch 'main' into fix-amp-module-1
35C4n0r 1212eda
wip
35C4n0r 8d94feb
wip
35C4n0r 0a41708
Merge branch 'main' into fix-amp-module-1
35C4n0r 22c7c85
chore: update amp version
35C4n0r 7295399
chore: bump module version
35C4n0r b1315f4
Merge branch 'main' into fix-amp-module-1
35C4n0r a3b3292
Merge branch 'main' into fix-amp-module-1
DevelopmentCats 4674eac
Remove automated dependency management section
35C4n0r 7241175
chore: bump version
35C4n0r File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,7 +55,7 @@ variable "install_agentapi" { | |
| variable "agentapi_version" { | ||
| type = string | ||
| description = "The version of AgentAPI to install." | ||
| default = "v0.10.0" | ||
| default = "v0.11.1" | ||
| } | ||
|
|
||
| variable "cli_app" { | ||
|
|
@@ -160,6 +160,16 @@ variable "mcp" { | |
| default = null | ||
| } | ||
|
|
||
| variable "mode" { | ||
| type = string | ||
| description = "Set the agent mode (free, rush, smart) — controls the model, system prompt, and tool selection. Default: smart" | ||
| default = "" | ||
| validation { | ||
| condition = contains(["", "free", "rush", "smart"], var.mode) | ||
| error_message = "Invalid mode. Select one from (free, rush, smart)" | ||
| } | ||
| } | ||
|
|
||
| data "external" "env" { | ||
| program = ["sh", "-c", "echo '{\"CODER_AGENT_TOKEN\":\"'$CODER_AGENT_TOKEN'\",\"CODER_AGENT_URL\":\"'$CODER_AGENT_URL'\"}'"] | ||
| } | ||
|
|
@@ -170,6 +180,7 @@ locals { | |
| default_base_config = jsonencode({ | ||
| "amp.anthropic.thinking.enabled" = true | ||
| "amp.todos.enabled" = true | ||
| "amp.terminal.animation" = false | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice. |
||
| }) | ||
|
|
||
| user_config = jsondecode(var.base_amp_config != "" ? var.base_amp_config : local.default_base_config) | ||
|
|
@@ -237,6 +248,7 @@ module "agentapi" { | |
| ARG_AMP_START_DIRECTORY='${var.workdir}' \ | ||
| ARG_AMP_TASK_PROMPT='${base64encode(var.ai_prompt)}' \ | ||
| ARG_REPORT_TASKS='${var.report_tasks}' \ | ||
| ARG_MODE='${var.mode}' \ | ||
| /tmp/start.sh | ||
| EOT | ||
|
|
||
|
|
||
2 changes: 0 additions & 2 deletions
2
registry/coder-labs/modules/sourcegraph-amp/scripts/install.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,6 @@ | ||
| #!/bin/bash | ||
| set -euo pipefail | ||
|
|
||
| source "$HOME"/.bashrc | ||
|
|
||
| # ANSI colors | ||
| BOLD='\033[1m' | ||
| GREEN='\033[0;32m' | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we explicitly set it to
smart?