feat: add group and order inputs to windows-rdp module #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the group and order variable inputs to the windows-rdp module to allow grouping and ordering of apps in the UI presentation. This brings the windows-rdp module in line with other modules that were updated in PR #123. Fixes #146 Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
matifali
reviewed
Jun 11, 2025
- Remove order and group parameters from rdp-docs app as it's just documentation - Update display_name from 'Local RDP' to 'Local RDP Docs' for clarity Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
Bumps version from 1.0.18 to 1.1.0 to reflect the new group and order functionality. Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
Contributor
❌ Version Bump Validation FailedBump Type: Module versions need to be updated but haven't been bumped yet. Required Actions:
Script Output:
|
Fixes CI formatting check by aligning version parameter spacing. Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
matifali
reviewed
Jun 11, 2025
Comment on lines
48
to
49
| source = "registry.coder.com/coder/windows-rdp/coder" | ||
| version = "1.0.18" | ||
| version = "1.2.0" |
Member
There was a problem hiding this comment.
@DevelopmentCats I think there is a bug and the script is bumping the version by two minor versions.
Contributor
Author
|
You're right! I see the issue - the script bumped from 1.1.0 to 1.2.0 when it should have gone from 1.0.18 to 1.1.0. Should I manually fix the version back to 1.1.0 in the README? |
Member
Yes, do a manual fix for now. |
Manually fixes version from 1.2.0 back to 1.1.0 due to version bump script bug. The correct version should be 1.1.0 (from 1.0.18 + minor bump). Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
matifali
approved these changes
Jun 11, 2025
Member
matifali
left a comment
matifali
left a comment
There was a problem hiding this comment.
This looks good. Thanks Blink
Contributor
Author
|
Thank you for the review and approval! 🎉 |
Removes terraform_1.5.7_linux_amd64.zip that was accidentally included in the PR. Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
groupandordervariable inputs to the windows-rdp module to allow grouping and ordering of apps in the UI presentation.This brings the windows-rdp module in line with other modules that were updated in PR #123.
Changes:
ordervariable with typenumberand defaultnullgroupvariable with typestringand defaultnullcoder_appresources to use the neworderandgroupparametersFixes #146