Skip to content

fix: do not start coder service during the image build #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

fix: do not start coder service during the image build #211

merged 1 commit into from
Mar 17, 2025

Conversation

@matifali
Copy link
Member

@matifali matifali commented Mar 14, 2025 •
edited
Loading

Closes #180
This will make the Coder service start when the image is deployed and should create a unique deployment ID.

@matifali
fix: do not start coder service during the image build
11883cb 
Solves #180 
This will make the Coder service install when the image is deployed and should create a unique deployment ID.
@matifali
Copy link
Member Author

matifali commented Mar 14, 2025

Testing it here: https://github.com/coder/packages/actions/runs/13865367237/job/38803215754

@matifali matifali merged commit de9cab0 into main Mar 17, 2025
2 checks passed
@matifali matifali mentioned this pull request Mar 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bpmct bpmct bpmct approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wipe deployment ID and any other Coder-specific information before imaging

2 participants

@matifali @bpmct