🤖 fix: resolve race conditions in stream error handling and test flakiness #880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasK33
force-pushed
the
fix-stream-error-race-conditions
branch
from
fdc939e to
829ec28
Compare
This comment has been minimized.
This comment has been minimized.
- Make debugTriggerStreamError async: - Await in-flight partial writes before writing error state - Await processingPromise to ensure stream cleanup completes - Keep manual error handling (abort alone causes clean break, not throw) - Fix race condition in error catch block: await partial writes before writing error state to prevent inconsistent partial.json - Test fixes: - Pass toolPolicy on resume to match original message (tools disabled) - Add delay after resume to let history update complete
ThomasK33
force-pushed
the
fix-stream-error-race-conditions
branch
from
829ec28 to
50675c3
Compare
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ammario
pushed a commit
that referenced
this pull request
Dec 3, 2025
## Summary Add comprehensive E2E tests covering window lifecycle, IPC robustness, streaming edge cases, persistence, and error display. These tests target recent regression patterns. ## Recent Regressions Addressed | Regression | Test Coverage | |------------|---------------| | `MockBrowserWindow.isDestroyed()` (#863) | IPC stability tests verify no crashes during heavy IPC | | IPC send to destroyed window (#859) | `ipcRobustness.spec.ts` - concurrent IPC operations | | Duplicate IPC handler registration (#851) | `windowLifecycle.spec.ts` - rapid IPC calls test | | Stream error handling (#880) | `streamEdgeCases.spec.ts` + `errorDisplay.spec.ts` | ## New Test Files (26 tests total) - **windowLifecycle.spec.ts** (6 tests): window operations, IPC stability under load - **ipcRobustness.spec.ts** (4 tests): concurrent IPC calls, state preservation - **streamEdgeCases.spec.ts** (6 tests): streaming during UI operations, error scenarios - **persistence.spec.ts** (4 tests): chat history, settings, mode persistence - **errorDisplay.spec.ts** (6 tests): error messages display, recovery flows ## Infrastructure Changes - **Error mock scenarios**: rate limit, server error, network error scenarios - **Stream timeline capture**: now handles `stream-error` events (previously only `stream-end`) - **CI matrix**: Linux (comprehensive, 47 tests) + macOS (window lifecycle, 6 tests) ## CI Configuration ```yaml matrix: include: - os: linux # Comprehensive E2E tests - os: macos # Window lifecycle tests only (platform-dependent) ``` _Generated with `mux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
debugTriggerStreamErrorasync and awaitprocessingPromiseto ensure error handling completes before returning (eliminates duplicate error-handling logic)partial.jsontoolPolicyon resume to match original message (tools disabled → text output)Generated with
mux