feat: add e2e test harness and accessibility polish #88
Conversation
ThomasK33
force-pushed
the
thomask33/10-07-add_playwright_e2e_and_a11y
branch
3 times, most recently
from
87e20e8 to
6b62029
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
ThomasK33
force-pushed
the
thomask33/10-07-add_playwright_e2e_and_a11y
branch
from
6b62029 to
9785f01
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
ThomasK33
force-pushed
the
thomask33/10-07-add_playwright_e2e_and_a11y
branch
2 times, most recently
from
e6cfd80 to
0347479
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
ThomasK33
force-pushed
the
thomask33/10-07-add_playwright_e2e_and_a11y
branch
2 times, most recently
from
c4ce0ce to
f710768
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
ThomasK33
force-pushed
the
thomask33/10-07-add_playwright_e2e_and_a11y
branch
from
f710768 to
25810bd
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
ThomasK33
force-pushed
the
thomask33/10-07-add_playwright_e2e_and_a11y
branch
from
4235d5d to
3825a2a
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. |
ThomasK33
force-pushed
the
thomask33/10-07-add_playwright_e2e_and_a11y
branch
from
bab7cc3 to
257b36e
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
|
@codex review |
1 similar comment
|
@codex review |
ThomasK33
force-pushed
the
thomask33/10-07-add_playwright_e2e_and_a11y
branch
4 times, most recently
from
f6f2b8f to
4545575
Compare
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. |
ThomasK33
force-pushed
the
thomask33/10-07-add_playwright_e2e_and_a11y
branch
2 times, most recently
from
cd124a9 to
1b89b95
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. |
ThomasK33
force-pushed
the
thomask33/10-07-add_playwright_e2e_and_a11y
branch
3 times, most recently
from
964eb2b to
4095779
Compare
ThomasK33
force-pushed
the
thomask33/10-07-add_playwright_e2e_and_a11y
branch
2 times, most recently
from
741dd94 to
096db6d
Compare
ammario
left a comment
ammario
left a comment
There was a problem hiding this comment.
is there any regression risk with this PR? seems only minor changes to prod code and mostly testing. If no regression risk then I'll leave the health of the e2e codebase to you and decline to review.
ThomasK33
force-pushed
the
thomask33/10-07-add_playwright_e2e_and_a11y
branch
from
096db6d to
22f781d
Compare
Introduce Playwright-driven Electron e2e runner with mock AI scenario to capture deterministic transcripts and videos for review flows. Seed test config via CMUX_TEST_ROOT, adjust Config to honor it, and teach main process to boot against the dev server during e2e runs. Stub mermaid in Vite to keep captures predictable and expand tsconfig coverage for new test sources. Harden Bash and StreamManager tests for CI timing variance. Improve keyboard and screen-reader access across chat transcript, command palette, slider, sidebar, and toast UI. Signed-off-by: Thomas Kosiewski <tk@coder.com> fix: align git status parser with ref order Change-Id: I7afe82dc1d8eb76f0c78bd6c60571a7460dfcf55 Signed-off-by: Thomas Kosiewski <tk@coder.com> fix: emit abort event and cancel existing mock streams - Emit stream-abort event when stopping mock streams to mirror real streaming behavior - Cancel any existing stream before starting a new one to prevent timer corruption - Addresses Codex review comments about mock stream lifecycle management Change-Id: I0a95493aa15dc0eda71a5c31b09b3844eeaf8187 Signed-off-by: Thomas Kosiewski <tk@coder.com> fix: persist mock stream messages to history on completion - Call HistoryService.updateHistory when stream-end fires in mock mode - Mirrors real StreamManager behavior to persist completed messages - Prevents empty assistant entries in chat.jsonl after mock runs - Addresses Codex review comment about mock persistence Change-Id: I4f4cd7fe27355a561cd4e2193a4045424918dd1e Signed-off-by: Thomas Kosiewski <tk@coder.com>
ThomasK33
force-pushed
the
thomask33/10-07-add_playwright_e2e_and_a11y
branch
from
22f781d to
74e9e09
Compare
I got it. Yeah, I also think that it shouldn't break anything in the app, but since it was a bigger change, I wanted to have you ACK it. |
2 participants
Introduce Playwright-driven Electron e2e runner with mock AI scenario to capture deterministic transcripts and videos for review flows.
Seed test config via CMUX_TEST_ROOT, adjust Config to honor it, and teach main process to boot against the dev server during e2e runs.
Stub mermaid in Vite to keep captures predictable and expand tsconfig coverage for new test sources.
Harden Bash and StreamManager tests for CI timing variance.
Improve keyboard and screen-reader access across chat transcript, command palette, slider, sidebar, and toast UI.