🤖 ci: add smoke test to catch MockBrowserWindow regressions #875
+128
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ibetitsmike
force-pushed
the
playwright-test-details-review
branch
3 times, most recently
from
0af5d59 to
1e7d1b8
Compare
Enhanced smoke-test.sh to exercise IPC and WebSocket flows that use MockBrowserWindow methods like isDestroyed(). Added smoke-test job to CI that runs on merge queue. The test: - Creates a project via IPC - Creates a workspace via IPC (triggers isDestroyed checks) - Subscribes to workspace chat via WebSocket This would have caught the regression in commit 3ca9c7e where isDestroyed() was added to ipcMain.ts but not to MockBrowserWindow in src/cli/server.ts. _Generated with mux_
ibetitsmike
force-pushed
the
playwright-test-details-review
branch
from
1e7d1b8 to
2103b36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an npm-based smoke test to CI that validates IPC and WebSocket functionality, catching bugs like the
isDestroyed()regression before they reach users.Changes:
scripts/smoke-test.sh- Runs the app headlessly and tests IPC channels + WebSocket connectivity.github/workflows/ci.yml- Newnpm-smoke-testjob in merge queue (port 3001, parallel with docker smoke test)Generated with
mux