🤖 fix: correct Docker smoke test version check #869
Merged
+34
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ibetitsmike
force-pushed
the
fix-docker-smoke-test
branch
from
146c517 to
20b8404
Compare
- Fix version field check: use git_describe instead of version - Bundle server with esbuild (~8MB) instead of copying node_modules (~2GB) - Final image size reduced from ~2GB to ~365MB - Only copy native modules (@lydell/node-pty) needed at runtime
ibetitsmike
force-pushed
the
fix-docker-smoke-test
branch
from
20b8404 to
221c816
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Docker smoke test and significantly improve Docker image size.
Changes
Fix version field check - use
git_describeinstead ofversion(the/versionendpoint returnsgit_describe)Bundle server with esbuild - reduces runtime dependencies from ~2GB
node_modulesto ~8MB bundle@lydell/node-pty) are kept externaljsonc-parserto avoid UMD bundling issuesResults
Generated with
mux