🤖 fix: initialize git repos in e2e fixtures #868
Merged
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibetitsmike
force-pushed
the
fix-e2e-test-git-errors
branch
from
2cd19e0 to
f01d454
Compare
The e2e test fixtures created directories but didn't run git init, causing listBranches() to fail with 'Not a git repository' errors. These errors were logged but didn't fail tests since the tests don't rely on branch-loading functionality. Fix: run 'git init -q' for both projectPath and workspacePath so the fixtures behave like real projects. _Generated with mux_
ibetitsmike
force-pushed
the
fix-e2e-test-git-errors
branch
from
f01d454 to
a6ad677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The e2e test fixtures created directories but didn't run
git init, causinglistBranches()to fail with 'Not a git repository' errors.These errors were logged but didn't fail tests since the tests don't rely on branch-loading functionality - they were just noise in the CI output.
Fix: run
git init -qfor both projectPath and workspacePath so the fixtures behave like real projects.Generated with
mux