🤖 feat: add mux-server integration tests #867
Closed
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add comprehensive integration tests for the mux-server HTTP/WebSocket API: - Health and version endpoint tests - Authentication tests (bearer token for HTTP, query param for WebSocket) - IPC channel routing tests (project:list, providers:list, etc.) - WebSocket subscription tests (workspace:metadata, workspace:activity) - --add-project CLI flag test Tests use real server instances with isolated MUX_ROOT directories. Each test suite gets its own server on a random port. Test infrastructure in serverTestUtils.ts provides: - Server lifecycle management (start/stop) - Test directory setup with optional git repo - IPC request helpers - WebSocket connection and message helpers Run with: TEST_INTEGRATION=1 bun x jest tests/server/server.test.ts _Generated with mux_
Address Codex review - wrap test suite in describeIntegration to skip when TEST_INTEGRATION is not set, matching the pattern used by other integration tests in tests/ipcMain/.
Fix TypeScript path resolution in CI where relative paths may not resolve correctly across different workspace configurations.
The mux-server architecture changed from IPC to ORPC. Server tests already exist in src/cli/server.test.ts covering the new ORPC endpoints. These tests were based on the old IPC-based server which no longer exists.
ibetitsmike
force-pushed
the
mux-server-ui-tests
branch
from
ab60372 to
5b4d108
Compare
Contributor
Author
|
Closing this PR - the mux-server architecture changed from IPC to ORPC while I was writing these tests. Comprehensive server tests already exist in The IPC-based tests I wrote are now obsolete since the IPC infrastructure no longer exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive integration tests for the mux-server HTTP/WebSocket API.
Tests cover:
Test infrastructure:
Running:
make build-main # Required first TEST_INTEGRATION=1 bun x jest tests/server/server.test.tsGenerated with
mux