🤖 fix: spacebar voice input race condition #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation assumed space was held when the recording effect ran, but React effects are async. If the user released space during microphone permission request or other delays, spaceHeldRef would incorrectly be true, blocking the subsequent space press from sending the transcription. Fix: Track global key state at module level (outside React lifecycle) and check actual state when effect runs. Also handles window blur to reset state when user switches away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation assumed space was held when the recording effect ran, but React effects are async. If the user released space during microphone permission request or other delays,
spaceHeldRefwould incorrectly betrue, blocking the subsequent space press from sending the transcription.Fix: Track global key state at module level (outside React lifecycle) and check actual state when effect runs. Also handles window blur to reset state when user switches away.
Generated with
mux