🤖 fix: prevent model selection reset in creation mode #786
+31
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues causing the wrong model to be used when creating workspaces:
Stale React state: The
handleSendcallback inuseCreationWorkspacecapturedsendMessageOptionsfromuseSendMessageOptions, but that hook's state updates were delayed byrequestAnimationFramebatching inusePersistedState. If the user selected a model and clicked send before the next animation frame, the old model value would be used.Effect overwriting selection: The useEffect that initialized the model to the default when entering creation mode could re-run and overwrite the user's selection if
defaultModelchanged for any reason.Fixes:
getSendOptionsFromStorageinstead of relying on potentially-stale React statedefaultModelchangeAlso added
modefield togetSendOptionsFromStoragereturn value for parity withuseSendMessageOptions.Generated with
mux