fix: fix web terminals not spawning for electron #736
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/desktop/terminalWindowManager.ts
Outdated
| query: { workspaceId }, | ||
| }); | ||
| } else { | ||
| // Development mode - load from Vite dev server | ||
| await terminalWindow.loadURL( |
There was a problem hiding this comment.
In openTerminalWindow the non-packaged path (lines 80‑84) always loads the Vite dev server when app.isPackaged is false, but dist/E2E runs set MUX_E2E_LOAD_DIST=1 and skip the dev server (see tests/e2e/electronTest.ts around lines 127‑210). In that configuration the main window serves built files while terminal windows still target http://localhost:5173/..., so terminals never load. Previously the NODE_ENV check loaded the built terminal.html for this scenario; this change regresses dist-mode terminal windows unless the app is fully packaged.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
No description provided.