🤖 fix: stabilize storybook theme by forcing context state #712
+166
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Updated |
Collaborator
Author
|
Updated
|
Collaborator
Author
|
Added a manual theme toggle button to the Storybook preview decorator. Why: Behavior:
|
ammar-agent
force-pushed
the
fix-storybook-theme-flakiness
branch
from
771f588 to
5c1acee
Compare
Member
|
@ethanndickson gonna turn in soon for the night if this is bothering you and this PR seems dead for more than 10m feel free to take it over. |
ethanndickson
force-pushed
the
fix-storybook-theme-flakiness
branch
from
e0d907a to
5e375d1
Compare
ammar-agent
force-pushed
the
fix-storybook-theme-flakiness
branch
4 times, most recently
from
d8a5e4b to
95b8022
Compare
ThemeProvider now detects when it's nested under a parent with forcedTheme and defers to that parent's theme value. This ensures Storybook/Chromatic's forced theme decorator isn't overridden by the app's own ThemeProvider. Changes: - ThemeProvider accepts forcedTheme prop and tracks isForced in context - Nested providers inherit parent's theme when parent has forcedTheme - Storybook decorator applies theme synchronously before React renders - Added tests for ThemeContext forced theme behavior _Generated with `mux`_
ammar-agent
force-pushed
the
fix-storybook-theme-flakiness
branch
from
1bfa4a0 to
2dbc126
Compare
ammario
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flaky visual diffs in Storybook where the theme would flash from default (light) to selected (dark) on load.
Changes
ThemeProviderto accept aforcedThemeprop that overrides internal state and persistence.preview.tsxto useforcedThemeinstead of auseEffect-based synchronization component.This ensures the correct theme is applied during the first render pass, eliminating the flash and preventing Storybook from polluting local storage.