🤖 refactor: use message queue for compact continue messages #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ethanndickson
force-pushed
the
compact-messages-queue-system
branch
from
782c367 to
84036aa
Compare
Previously, compact continue messages were handled by a frontend hook (useAutoCompactContinue) that watched for completed compactions and then sent the continue message. This introduced complexity, race conditions, and required tracking processed message IDs. Now leverages the existing message queue system: - Backend queues continue message when compaction starts - Queue auto-sends when compaction stream ends (existing behavior) - Continue message shown in queue UI during compaction - Proper cleanup on all error paths - Strip editMessageId to prevent truncation failures after compaction Net reduction of 134 lines. Simpler, more reliable, better UX.
ethanndickson
force-pushed
the
compact-messages-queue-system
branch
from
84036aa to
de386b3
Compare
This was referenced Nov 18, 2025
ibetitsmike
approved these changes
Nov 20, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 21, 2025
_Generated with `mux`_ ## Stack 1. #685 1. #683 1. #670 ⬅ This PR 1. #650 (base) ## Summary Moves history compaction handling from WorkspaceStore (frontend) to agentSession (backend) to centralize server-side operations and fix race conditions. Relates to #651. ## Changes ### Backend (agentSession.ts) - Added `handleCompactionCompletion()` - detects compaction stream-end, extracts summary from event.parts, performs history replacement - Added `handleCompactionAbort()` - handles Ctrl+A (accept early with `[truncated]`) and Ctrl+C (cancel) flows - Added `performCompaction()` - atomically replaces chat history with summary message including cumulative usage - Implemented `abandonPartial` flag flow from IPC through to StreamAbortEvent - Extracts truncated message content from history instead of partialService ### Frontend (WorkspaceStore.ts) - Removed `handleCompactionCompletion()` and `handleCompactionAbort()` methods - Removed `performCompaction()` method - Removed `processedCompactionRequestIds` Set - Simplified `cancelCompaction()` - just calls `interruptStream` with `abandonPartial: true` - Fixed Ctrl+A keybind to pass `abandonPartial: false` for early accept ### Shared - Updated `StreamAbortEvent` to include `abandonPartial?: boolean` - `historyService.clearHistory()` now returns deleted sequence numbers - Created `calculateCumulativeUsage()` utility in `displayUsage.ts` to extract and sum usage from messages ## Testing - [x] Manual: `/compact` completes successfully - [x] Manual: Ctrl+A during compaction accepts early with `[truncated]` - [x] Manual: Ctrl+C during compaction cancels and enters edit mode - [x] Verify cumulative usage preserved across multiple compactions
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 25, 2025
## Stack 1. #685 1. #683 ⬅ This PR 1. #670 1. #650 (base) ## Summary Adds automatic context compaction that triggers at 70% usage, with progressive countdown warnings starting at 60%. <img width="905" height="155" alt="image" src="https://github.com/user-attachments/assets/b0db20c5-c377-44bb-891c-f8ddadd561c8" /> <img width="891" height="194" alt="image" src="https://github.com/user-attachments/assets/6385cfd2-5e3c-45ec-afce-935dae56ad1a" /> Relates to #651. ## Key Changes **Auto-Compaction:** - Triggers automatically when current context usage reaches 70% of model's context window - Queues user's message to send after compaction completes - Includes image parts in continue messages **Progressive Warnings:** - Shows countdown at 60-69% usage: "Context left until Auto-Compact: X% remaining" - Shows urgent message at 70%+: "⚠️ Approaching context limit. Next message will trigger auto-compaction." **Implementation:** - New `shouldAutoCompact()` utility centralizes threshold logic with configurable constants - Returns `{ shouldShowWarning, usagePercentage, thresholdPercentage }` - Uses **last usage entry** (current context size) to match UI token meter display - Excludes historical usage from threshold check to prevent infinite compaction loops - `ContinueMessage` type now includes optional `imageParts` ## Technical Details **Usage Calculation:** The auto-compaction check uses the most recent usage entry from `usageHistory` to calculate the current context size. This matches the percentage displayed in the UI token meter and correctly handles post-compaction scenarios: - **Before compaction**: Last entry represents full context → triggers at 70% correctly - **After compaction**: Last entry excludes historical usage → resets to actual context size - **Historical usage preserved**: Remains in usage history for cost tracking, but not used for threshold calculations This prevents the infinite loop where post-compaction workspaces would continuously re-compact because historical usage tokens were being included in the threshold check. ## Future Work Future PRs will add user settings to configure auto-compaction (enable/disable, custom threshold). _Generated with `mux`_
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 25, 2025
## Stack 1. #685 ⬅ This PR 1. #683 1. #670 1. #650 (base) Relates to #651. Adds per-workspace settings for auto-compaction (any percentage between 50 and 90): <img width="305" height="130" alt="image" src="https://github.com/user-attachments/assets/039e19d9-d95c-4249-8274-6a34116ee062" /> <img width="295" height="163" alt="image" src="https://github.com/user-attachments/assets/6095b100-732e-4c2c-bc39-3e66298245e4" /> **New Features:** - Toggle to enable/disable auto-compaction - Configurable threshold percentage (50-90%, default 70%) - Settings persist to localStorage and sync across tabs - UI integrated into right sidebar below existing settings **Implementation:** - Extracted threshold constants to `ui.ts` for DRY - Created reusable `useClampedNumberInput` hook for numeric input validation - Updated `shouldAutoCompact` to accept settings parameters - Follows existing patterns (uses `HelpIndicator` for tooltips) Settings are forked with workspace and cleaned up on workspace deletion. _Generated with `mux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack
Problem
Compact continue messages were handled by a frontend hook that watched workspace states and manually sent continue messages after compaction. This was complex, had potential race conditions, and poor separation of concerns.
Relates to #651.
Solution
Use the existing message queue system:
Benefits: Simpler (-134 lines), more reliable, better UX (continue message visible in queue).
Generated with
mux