Skip to content

Conversation

@kylecarbs
Copy link
Member

Summary

  • add global theme provider with persisted light/dark toggle and title bar control
  • expand css variables with light palette and early bootstrapping script
  • wire storybook toolbar + chromatic modes to render both themes

Testing

  • make typecheck

_Generated with _

@kylecarbs kylecarbs force-pushed the mux-light-theme-toggle branch 8 times, most recently from 93b7180 to d45fce1 Compare November 20, 2025 16:03
- User message text: text-slate-100 → text-foreground
- JSON debug view: text-white/80 → text-muted-foreground
- History hidden message: bg-white/[0.03] → bg-muted/30
- Image borders: border-white/10 → border-separator
- Fix Tailwind classnames order warnings
- keep user message text/border matching prior dark theme values
- add theme variables for debug/attachment/line numbers with light-mode overrides
- replace hardcoded colors so light mode looks intentional
@kylecarbs kylecarbs force-pushed the mux-light-theme-toggle branch from d45fce1 to 13cc5fc Compare November 21, 2025 14:56
- add theme tokens for command palette + sidebar tab text
- dark mode values mirror previous appearance; light mode uses darker fg
- darken "light" text token and code keywords for diff readability
- switch shiki syntax highlighting to a light theme when UI theme=light
- thread theme through diff renderer to keep diffs consistent
- replace hover:text-white with theme-aware hover text color
@kylecarbs kylecarbs force-pushed the mux-light-theme-toggle branch from 13cc5fc to 7601b7f Compare November 21, 2025 14:57
@kylecarbs kylecarbs merged commit 4591c44 into main Nov 21, 2025
13 checks passed
@kylecarbs kylecarbs deleted the mux-light-theme-toggle branch November 21, 2025 15:30
ibetitsmike added a commit that referenced this pull request Nov 26, 2025
PR #637 accidentally removed the DirectoryPickerModal integration that was
added in PR #682. This restores:

- Desktop mode: native pickDirectory() dialog
- Browser mode: web-based DirectoryPickerModal component
- Conditional Browse button based on platform capabilities
- Theme-aware styling (text-foreground instead of hardcoded text-white)

Also adds ProjectCreateModal.stories.tsx with 8 Storybook tests covering:
- Basic modal rendering
- Typing path manually
- Browse button opening directory picker
- Directory navigation
- Path selection flow
- Full end-to-end flow
- Cancel behavior
- Validation errors
github-merge-queue bot pushed a commit that referenced this pull request Nov 26, 2025
PR #637 accidentally removed the DirectoryPickerModal integration added
in PR #682.

## Changes

**ProjectCreateModal.tsx:**
- Restored desktop mode: native `pickDirectory()` dialog
- Restored browser mode: web-based `DirectoryPickerModal` component  
- Browse button conditionally shown based on platform capabilities
- Theme-aware styling (`text-foreground` instead of hardcoded
`text-white`)

**ProjectCreateModal.stories.tsx (new):**
- 8 Storybook tests covering directory picker flow
- Tests for navigation, selection, cancel, and validation errors

---
_Generated with `mux`_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant