Skip to content

🤖 fix: relocate Seti font asset #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylecarbs merged 1 commit into from
Nov 16, 2025
Merged

🤖 fix: relocate Seti font asset #632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 src/browser/assets/file-icons/seti.woff → public/seti.woff
View file
Open in desktop
File renamed without changes.
5 changes: 3 additions & 2 deletions scripts/update_seti_icons.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@ set -euo pipefail

ROOT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
ASSET_DIR="$ROOT_DIR/src/browser/assets/file-icons"
FONT_PATH="$ROOT_DIR/public/seti.woff"

mkdir -p "$ASSET_DIR"

curl -sSL "https://raw.githubusercontent.com/microsoft/vscode/main/extensions/theme-seti/icons/seti.woff" \
-o "$ASSET_DIR/seti.woff"
-o "$FONT_PATH"

curl -sSL "https://raw.githubusercontent.com/microsoft/vscode/main/extensions/theme-seti/icons/vs-seti-icon-theme.json" \
-o "$ASSET_DIR/seti-icon-theme.json"

echo "Updated Seti icon assets in $ASSET_DIR"
echo "Updated Seti icon assets in $ASSET_DIR and font at $FONT_PATH"
2 changes: 1 addition & 1 deletion src/browser/styles/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

@font-face {
font-family: "Seti";
src: url("../assets/file-icons/seti.woff") format("woff");
src: url("/seti.woff") format("woff");
font-weight: normal;
Comment on lines 13 to 16
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid absolute Seti font URL in packaged builds

@font-face now references the font as /seti.woff. That works while the dev server runs on http://localhost, but the packaged app uses Vite’s base: "./" and loads HTML via BrowserWindow.loadFile, so URLs starting with / resolve to file:///seti.woff (the filesystem root) rather than the bundled dist/seti.woff. Consequently the Seti icon font won’t load in production and file icons disappear. Use a path relative to the CSS file (e.g. ./seti.woff) or prefix with import.meta.env.BASE_URL so the asset resolves under both file and http protocols.

Useful? React with 👍 / 👎.

font-style: normal;
font-display: swap;
Expand Down