🤖 fix: replace /bin/bash with /usr/bin/env bash for portability #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace hardcoded /bin/bash shebangs with /usr/bin/env bash for better portability across different systems, particularly NixOS where /bin/bash does not exist. Changes: - Makefile: Update SHELL variable for non-Windows systems - docs/init-hooks.md: Update example script shebangs - scripts/setup-macos-signing.sh: Update shebang - vscode/scripts/create-icon.sh: Update shebang /usr/bin/env bash resolves bash from PATH, making scripts work on systems where bash is not in /bin (e.g., NixOS installs bash in /nix/store/...). _Generated with `mux`_
Restore and expand the Windows-specific context that was removed, explaining why we use different SHELL values for different platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace hardcoded
/bin/bashshebangs with/usr/bin/env bashfor better portability across different systems, particularly NixOS where/bin/bashdoes not exist.Changes
Why
/usr/bin/env bashresolves bash from PATH, making scripts work on systems where bash is not in/bin(e.g., NixOS installs bash in/nix/store/...). This is a standard practice for portable shell scripts.Generated with
mux