🤖 fix: vim-aware interrupt keybinds (Ctrl+C in vim, Esc otherwise) #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ctrl+C conflicts with the standard copy shortcut on Linux and Windows. Changed interrupt stream keybind to Ctrl+D on these platforms while keeping Ctrl+C on macOS (where Cmd+C is used for copy). _Generated with `cmux`_
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Changed interrupt stream keybind strategy to be vim-mode aware: - Vim mode enabled: Ctrl+C (familiar from terminal interrupt) - Vim mode disabled: Esc (intuitive cancel/stop key) This avoids conflicts with copy operations while providing the most natural keybind for each mode. In vim mode, Ctrl+C still allows copy when text is selected. In non-vim mode, Esc is free for interrupt since it's not needed for mode transitions. _Generated with `cmux`_
ibetitsmike
changed the title
In vim mode, Ctrl+C now always interrupts streams regardless of text selection. This is consistent with vim philosophy where: - Ctrl+C is for canceling/interrupting operations - Yank commands (y, yy, yiw, etc.) are used for copying This simplifies the behavior and makes it more predictable. Users in vim mode will use vim's native copy commands instead of Ctrl+C. _Generated with `cmux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed interrupt stream keybind strategy to be vim-mode aware:
This provides the most natural behavior for each mode while avoiding conflicts with standard operations.
Vim Mode Behavior
In vim mode, Ctrl+C always interrupts streams - consistent with vim philosophy:
y,yy,yiw, etc.) for copying insteadNon-Vim Mode Behavior
In non-vim mode:
Changes
INTERRUPT_STREAMintoINTERRUPT_STREAM_VIMandINTERRUPT_STREAM_NORMALuseAIViewKeybindsto acceptvimEnabledand select appropriate keybinddocs/vim-mode.mdGenerated with
cmux