Skip to content

🤖 fix: Ctrl+C no longer interrupts stream when text is selected #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deansheather wants to merge 1 commit into from
Closed

🤖 fix: Ctrl+C no longer interrupts stream when text is selected #559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/hooks/useAIViewKeybinds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,11 @@ export function useAIViewKeybinds({
}

// Normal stream interrupt (non-compaction)
// Allow interrupt in editable elements if there's no text selection
// Check for text selection anywhere - only interrupt if nothing is selected
// This way Ctrl+C works for both copy (when text is selected) and interrupt (when not)
const inEditableElement = isEditableElement(e.target);
let hasSelection = false;

if (inEditableElement) {
if (isEditableElement(e.target)) {
// For input/textarea elements, check selectionStart/selectionEnd
// (window.getSelection() doesn't work for form elements)
const target = e.target as HTMLInputElement | HTMLTextAreaElement;
Expand All @@ -85,7 +84,8 @@ export function useAIViewKeybinds({
hasSelection = (window.getSelection()?.toString().length ?? 0) > 0;
}

if ((canInterrupt || showRetryBarrier) && (!inEditableElement || !hasSelection)) {
// Only interrupt if there's no selection (allow Ctrl+C to copy when text is selected)
if ((canInterrupt || showRetryBarrier) && !hasSelection) {
e.preventDefault();
setAutoRetry(false); // User explicitly stopped - don't auto-retry
void window.api.workspace.interruptStream(workspaceId);
Expand Down