🤖 fix: require Node.js v20+ for Storybook #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was that Node.js v18.19.1 had a conflict with esbuild-register when loading Vite code in Storybook's config. Specifically, esbuild-register was trying to declare 'const __dirname' but it was already declared in the environment, causing a SyntaxError. Node.js v20.19.4 resolves this issue. Changes: - Add Node.js version check to Makefile (requires v20+) - Apply version check to all Storybook-related targets - Add --no-open flag to storybook dev to prevent xdg-open errors on headless machines - Provide helpful error message with instructions to upgrade using 'n' _Generated with `cmux`_
Make the browser opening behavior smart: - Detect if xdg-open is available - Only add --no-open flag if it's not available - Allows Storybook to open browser on machines that support it - Prevents xdg-open ENOENT errors on headless machines This way it works seamlessly on both developer machines with browsers and headless CI/test machines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Storybook was failing on this dev machine with:
This occurred because Node.js v18.19.1 had a conflict with esbuild-register when loading Vite code in Storybook's config. esbuild-register was trying to declare
const __dirnamebut it was already declared in the environment.Solution
Machine fix: Upgraded Node.js from v18.19.1 to v20.19.4 using the
nversion manager.Code fix: Added Node.js version check to Makefile to prevent this issue for others:
--no-openflag to storybook dev to prevent xdg-open errors on headless machinesVerification
Storybook now starts successfully:
Version check works correctly:
$ PATH="/old-node:$PATH" make storybook Error: Node.js v20 or higher is required Current version: v18Generated with
cmux