🤖 Fix: Use tilde path in SSH runtime to avoid process.env in renderer #458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression from #451 where was using
process.env.USERin renderer code, causing "process is not defined" error during workspace creation.Problem
After merging #451, workspace creation fails with:
The issue:
chatCommands.tsis renderer code that was trying to accessprocess.env.USERto construct SSH default paths. Theprocessglobal is not available in Electron renderer processes.Solution
Use tilde paths instead - Now that we have tilde resolution from #451, we can simply use
~/cmuxas the default SSHsrcBaseDir. The backend will resolve it viaruntime.resolvePath().Before:
After:
ESLint Rule
Added
no-restricted-globalsandno-restricted-syntaxrules to prevent futureprocess.envusage in renderer code:src/**/*.ts(x)This catches the issue at development time rather than runtime.
Testing
~/cmuxinstead of computed pathsGenerated with
cmux