fix: allow empty run layers to be pushed without force build meta #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Images of type application/vnd.docker.image.rootfs.diff.tar.gzip seem to break when you try to push metadata-only layers and the layers all share the same hash. This doesn't seem to be a problem with OCI images. Ref: coder/envbuilder#385
johnstcn
reviewed
Nov 8, 2024
| snapshot, err = s.snapshotter.TakeSnapshot(files, shdDelete, s.opts.ForceBuildMetadata) | ||
| forceBuildMetadata := s.opts.ForceBuildMetadata | ||
| if s.opts.Cache && len(s.opts.Destinations) > 0 && !s.opts.NoPush { | ||
| forceBuildMetadata = true |
Member
There was a problem hiding this comment.
We should probably log when we force-enable this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Images of type application/vnd.docker.image.rootfs.diff.tar.gzip seem to
break when you try to push metadata-only layers and the layers all share
the same hash. This doesn't seem to be a problem with OCI images.
Refs coder/envbuilder#385