fix: fix bug copying text in scrollback #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When users scroll back in terminal history and select text, the selection was incorrectly reading from the current screen buffer instead of the scrollback buffer, causing copied text to be wrong. Root cause: SelectionManager.getSelection() always called getLine() which reads screen buffer, ignoring the viewport scroll position (viewportY). Solution: Make getSelection() viewport-aware by checking viewportY and using getScrollbackLine() for rows in scrollback vs getLine() for rows in the screen buffer. This follows the same pattern used by the terminal's link detection code. Changes: - lib/selection-manager.ts: Updated getSelection() to handle viewport offset - lib/terminal.test.ts: Added 4 comprehensive test cases covering: - Selection entirely in scrollback - Selection spanning scrollback and screen - Selection when not scrolled (regression test) - Selection at top of scrollback history All tests pass. Fixes copy/paste from scrollback history.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.