feat: add hyperlink rendering #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix immediate scrolling: focus element immediately instead of delayed - Add mouse move throttling (16ms) to prevent event loop blocking - Make async link detection non-blocking - Integrate hyperlink rendering into 60fps render loop (no forced renders) - Fix viewport-aware coordinate conversion for scrolled content - Fix click handler to detect links at click time (no race conditions) - Fix CRITICAL scrollback indexing bug in Buffer.getLine - Was using inverted formula: scrollbackLength - y - 1 - Correct formula: y (WASM offset 0 = oldest, not newest) - Add comprehensive hyperlink test script (15 test scenarios) Performance improvements: - Removed expensive row scanning on every mouse move (~60 lines) - Hyperlink hover now smooth even with many links on screen - Scrolling works smoothly during hyperlink interaction - All hyperlinks clickable at any scroll position All tests pass (205/205)
- Replace 'Phase 3' comments with descriptive names - Update all link detection and rendering comments - Improve code readability without phase-based naming No functional changes - only comment updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.