-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add rearrange_hand functionality
#35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
b99a11a
uses sort(), crashes balatro
stirby 20858e8
Merge remote-tracking branch 'upstream/main' into rearrange-hand
stirby e60bbc2
revert time import
stirby abe1a3a
fixed rearrange hand
stirby 7ade635
added tests for rearrange hand
stirby 03be167
documented rearrange_hand function
stirby 154954c
stylua
stirby 306cdee
refactor: remove action from rearrange_hand
S1M0N38 15bf34e
test: remove action from rearrange_hand
S1M0N38 0dc978f
ci: do not run release_please for pull requests
S1M0N38 61c66d4
feat: add sort_id to card in game state
S1M0N38 635c9b7
fix: remove set_ranks and align_cards from rearrange_hand
S1M0N38 cb49c42
feat(utils): add sets_equal function
S1M0N38 70ffcd9
feat(log): add hand rearrange logging (WIP)
S1M0N38 b4fa7a7
docs: update docs/protocol-api.md with new sign for rearrange_hand
S1M0N38 a7f1ebc
style: format docs/protocol-api.md
S1M0N38 25c2d8b
test: update test runs with sort_id field
S1M0N38 89512f8
computed reorder index
stirby 40d0473
Merge remote-tracking branch 'upstream/main' into rearrange-hand
stirby File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -47,6 +47,10 @@ | |||||
| ---@field action "play_hand" | "discard" The action to perform | ||||||
| ---@field cards number[] Array of card indices (0-based) | ||||||
|
|
||||||
| ---@class RearrangeHandArgs | ||||||
| ---@field action "rearrange" The action to perform | ||||||
|
||||||
| ---@field action "rearrange" The action to perform | |
| ---@field action "rearrange_hand" The action to perform |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation specifies that the action parameter must be "rearrange_hand", but the type definition in types.lua defines it as "rearrange". This inconsistency should be resolved.