Skip to content

C2LC-433: Add keyboard shortcut for pen down toggle #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chosww wants to merge 3 commits into
base: develop-1.0
Choose a base branch
from
Open

C2LC-433: Add keyboard shortcut for pen down toggle #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96327c1
C2LC-433: Add keyboard shortcut for pen down toggle
chosww Jul 30, 2021
78a4d62
Merge branch 'develop-0.9' of https://github.com/codelearncreate/c2lc…
chosww Aug 9, 2021
ebdf0aa
C2LC-433: Merge develop-1.0 and resolve conflicts
chosww Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/keyboard.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ follows.
| Ctrl + Alt + p | playPauseProgram |
| Ctrl + Alt + r | refreshScene |
| Ctrl + Alt + s | stopProgram |
| Ctrl + Alt + n | penDownToggle |
| < | decreaseProgramSpeed |
| > | increaseProgramSpeed |
| ? | showHide |
Expand Down Expand Up @@ -89,6 +90,7 @@ with the starting key of a sequence. Those key bindings are as follows:
| Alt + p | playPauseProgram |
| Alt + r | refreshScene |
| Alt + s | stopProgram |
| Alt + n | penDownToggle |
| < | decreaseProgramSpeed |
| > | increaseProgramSpeed |
| ? | showHide |
Expand Down
4 changes: 4 additions & 0 deletions src/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -865,6 +865,10 @@ export class App extends React.Component<AppProps, AppState> {
this.handleChangeCharacterPosition('turnRight');
}
break;
case("penDownToggle"):
const currentPendownState = this.state.drawingEnabled;
this.handleTogglePenDown(!currentPendownState);
break;
case("changeToDefaultTheme"):
this.setStateSettings({theme: "mixed"});
break;
Expand Down
9 changes: 9 additions & 0 deletions src/KeyboardInputSchemes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export type ActionName =
| "announceScene"
| "decreaseProgramSpeed"
| "increaseProgramSpeed"
| "penDownToggle"
| "playPauseProgram"
| "refreshScene"
| "showHide"
Expand Down Expand Up @@ -321,6 +322,10 @@ const AltInputScheme: KeyboardInputScheme = Object.assign({
stopProgram: {
keyDef: { code: "KeyS", key: "s", altKey: true},
actionName: "stopProgram"
},
penDownToggle: {
keyDef: { code: "KeyN", key: "n", altKey: true},
actionName: "penDownToggle"
}
}, ExtendedKeyboardSequences);

Expand Down Expand Up @@ -387,6 +392,10 @@ const ControlAltInputScheme = Object.assign({
keyDef: {code: "KeyS", key: "s", altKey: true, ctrlKey: true},
actionName: "stopProgram"
},
penDownToggle: {
keyDef: { code: "KeyN", key: "n", altKey: true, ctrlKey: true},
actionName: "penDownToggle"
}
}, ControlAltExtendedKeyboardSequences);

export const KeyboardInputSchemes:KeyboardInputSchemesType = {
Expand Down