Skip to content

Conversation

@chosww
Copy link
Contributor

@chosww chosww commented Jul 30, 2021

See C2LC-431 for details.

keyDef: { code: "KeyS", key: "s", altKey: true},
actionName: "stopProgram"
},
expandAddNode: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now this is fine, but as we pick up more bindings (like the help key) that are the same between all schemes, we should probably make and reuse a "common" binding definition, like we do with extended keyboard sequences. I think a TODO here would be a good idea for now.

Copy link
Contributor Author

@chosww chosww Aug 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current keyboard shortcut combinations are likely to change, so I think it makes sense to wait until we talk about rework of the keyboard shortcut combinations.

@the-t-in-rtf
Copy link
Contributor

I left a small comment on the code changes, but was not able to perform QA in the time I had, as the preview deployment failed.

@the-t-in-rtf
Copy link
Contributor

I performed QA on this with a local copy of the branch. It works as expected on all browsers, and I confirmed that the change is equivalent to hitting the toggle, i.e.:

  1. Dragging and dropping with contracted nodes works as expected if you contract the nodes using the hotkey.
  2. Tab navigation works as expected if you contract the nodes using the hotkey.

@chosww chosww changed the base branch from develop-0.9 to develop-1.0 October 12, 2021 19:41
@sbates-idrc sbates-idrc linked an issue Jun 3, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a keyboard shortcut for expand and collapse add nodes

2 participants