fix: remove unneeded conditions

Author: kenjis

src/Authentication/Authenticators/Session.php

@@ -241,7 +241,7 @@ public function checkAction(UserIdentity $identity, string $token): bool
             throw new LogicException('Cannot get the User.');
         }
 
-        if ($token === '' || $token === '0' || $token !== $identity->secret) {
+        if ($token === '' || $token !== $identity->secret) {
             return false;
         }
 
@@ -767,7 +767,7 @@ private function issueRememberMeToken(): void
 
             // Reset so it doesn't mess up future calls.
             $this->shouldRemember = false;
-        } elseif ($this->getRememberMeToken() !== null && $this->getRememberMeToken() !== '' && $this->getRememberMeToken() !== '0') {
+        } elseif ($this->getRememberMeToken() !== null) {
             $this->removeRememberCookie();
 
             // @TODO delete the token record.
@@ -935,6 +935,9 @@ private function calcExpires(): Time
         return Time::createFromTimestamp($timestamp);
     }
 
+    /**
+     * @param non-empty-string $rawToken
+     */
     private function setRememberMeCookie(string $rawToken): void
     {
         /** @var Response $response */

src/Authentication/Passwords.php

@@ -112,7 +112,7 @@ public function check(string $password, ?User $user = null): Result
 
         $password = trim($password);
 
-        if ($password === '' || $password === '0') {
+        if ($password === '') {
             return new Result([
                 'success' => false,
                 'reason'  => lang('Auth.errorPasswordEmpty'),

src/Authentication/Passwords/NothingPersonalValidator.php

@@ -85,7 +85,7 @@ protected function isNotPersonal(string $password, ?User $user): bool
 
             // might be john.doe@example.com and we want all the needles we can get
             $emailParts = $this->strip_explode($localPart);
-            if ($domain !== null && $domain !== '' && $domain !== '0') {
+            if ($domain !== null && $domain !== '') {
                 $emailParts[] = $domain;
             }
             $needles = [...$needles, ...$emailParts];

src/Authentication/Traits/HasAccessTokens.php

@@ -97,7 +97,7 @@ public function accessTokens(): array
      */
     public function getAccessToken(?string $rawToken): ?AccessToken
     {
-        if ($rawToken === null || $rawToken === '' || $rawToken === '0') {
+        if ($rawToken === null || $rawToken === '') {
             return null;
         }
 

tests/Authentication/Filters/AbstractFilterTestCase.php

@@ -61,7 +61,7 @@ private function addRoutes(): void
     {
         $routes = service('routes');
 
-        $filterString = isset($this->routeFilter) && ($this->routeFilter !== '' && $this->routeFilter !== '0')
+        $filterString = isset($this->routeFilter) && ($this->routeFilter !== '')
             ? $this->routeFilter
             : $this->alias;