refactor: vendor/bin/rector

Author: kenjis

src/Authentication/Actions/Email2FA.php

@@ -78,7 +78,7 @@ public function handle(IncomingRequest $request)
 
         $identity = $this->getIdentity($user);
 
-        if (empty($identity)) {
+        if (! $identity instanceof UserIdentity) {
             return redirect()->route('auth-action-show')->with('error', lang('Auth.need2FA'));
         }
 

src/Authentication/Authenticators/AccessTokens.php

@@ -193,7 +193,7 @@ public function check(array $credentials): Result
      */
     public function loggedIn(): bool
     {
-        if (! empty($this->user)) {
+        if ($this->user instanceof User) {
             return true;
         }
 
@@ -226,7 +226,7 @@ public function loginById($userId): void
     {
         $user = $this->provider->findById($userId);
 
-        if (empty($user)) {
+        if (! $user instanceof User) {
             throw AuthenticationException::forInvalidUser();
         }
 

src/Authentication/Authenticators/Session.php

@@ -241,7 +241,7 @@ public function checkAction(UserIdentity $identity, string $token): bool
             throw new LogicException('Cannot get the User.');
         }
 
-        if (empty($token) || $token !== $identity->secret) {
+        if ($token === '' || $token === '0' || $token !== $identity->secret) {
             return false;
         }
 
@@ -485,7 +485,7 @@ private function setAuthAction(): bool
 
             $identity = $this->userIdentityModel->getIdentityByType($this->user, $action->getType());
 
-            if ($identity) {
+            if ($identity instanceof UserIdentity) {
                 $this->userState = self::STATE_PENDING;
 
                 $this->setSessionKey('auth_action', $actionClass);
@@ -767,7 +767,7 @@ private function issueRememberMeToken(): void
 
             // Reset so it doesn't mess up future calls.
             $this->shouldRemember = false;
-        } elseif ($this->getRememberMeToken()) {
+        } elseif ($this->getRememberMeToken() !== null && $this->getRememberMeToken() !== '' && $this->getRememberMeToken() !== '0') {
             $this->removeRememberCookie();
 
             // @TODO delete the token record.
@@ -804,7 +804,7 @@ public function loginById($userId): void
     {
         $user = $this->provider->findById($userId);
 
-        if (empty($user)) {
+        if (! $user instanceof User) {
             throw AuthenticationException::forInvalidUser();
         }
 

src/Authentication/Passwords.php

@@ -112,7 +112,7 @@ public function check(string $password, ?User $user = null): Result
 
         $password = trim($password);
 
-        if (empty($password)) {
+        if ($password === '' || $password === '0') {
             return new Result([
                 'success' => false,
                 'reason'  => lang('Auth.errorPasswordEmpty'),

src/Authentication/Passwords/CompositionValidator.php

@@ -37,7 +37,7 @@ class CompositionValidator extends BaseValidator implements ValidatorInterface
      */
     public function check(string $password, ?User $user = null): Result
     {
-        if (empty($this->config->minimumPasswordLength)) {
+        if ($this->config->minimumPasswordLength === 0) {
             throw AuthenticationException::forUnsetPasswordLength();
         }
 

src/Authentication/Passwords/NothingPersonalValidator.php

@@ -85,7 +85,7 @@ protected function isNotPersonal(string $password, ?User $user): bool
 
             // might be john.doe@example.com and we want all the needles we can get
             $emailParts = $this->strip_explode($localPart);
-            if (! empty($domain)) {
+            if ($domain !== null && $domain !== '' && $domain !== '0') {
                 $emailParts[] = $domain;
             }
             $needles = [...$needles, ...$emailParts];

src/Authentication/Passwords/ValidationRules.php

@@ -49,13 +49,13 @@ public function strong_password(string $value, ?string &$error1 = null, array $d
             $user = auth()->user();
         } else {
             /** @phpstan-ignore-next-line */
-            $user = empty($data) ? $this->buildUserFromRequest() : $this->buildUserFromData($data);
+            $user = $data === [] ? $this->buildUserFromRequest() : $this->buildUserFromData($data);
         }
 
         $result = $checker->check($value, $user);
 
         if (! $result->isOk()) {
-            if (empty($data)) {
+            if ($data === []) {
                 $error1 = $result->reason();
             } else {
                 $error2 = $result->reason();

src/Authentication/Traits/HasAccessTokens.php

@@ -97,7 +97,7 @@ public function accessTokens(): array
      */
     public function getAccessToken(?string $rawToken): ?AccessToken
     {
-        if (empty($rawToken)) {
+        if ($rawToken === null || $rawToken === '' || $rawToken === '0') {
             return null;
         }
 

src/Authorization/Traits/Authorizable.php

@@ -264,7 +264,7 @@ public function can(string ...$permissions): bool
                 return true;
             }
 
-            if (! count($this->groupCache)) {
+            if (count($this->groupCache) === 0) {
                 return false;
             }
 

src/Entities/Group.php

@@ -80,14 +80,14 @@ public function can(string $permission): bool
         $this->populatePermissions();
 
         // Check exact match
-        if (! empty($this->permissions) && in_array($permission, $this->permissions, true)) {
+        if ($this->permissions !== null && $this->permissions !== [] && in_array($permission, $this->permissions, true)) {
             return true;
         }
 
         // Check wildcard match
         $check = substr($permission, 0, strpos($permission, '.')) . '.*';
 
-        return ! empty($this->permissions) && in_array($check, $this->permissions, true);
+        return $this->permissions !== null && $this->permissions !== [] && in_array($check, $this->permissions, true);
     }
 
     /**