feat(cache): add native return types to all CacheInterface methods #9811
+108
−305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yassinedoghri
force-pushed
the
fix/cache-interface-2
branch
2 times, most recently
from
8065d0f to
622dd8b
Compare
yassinedoghri
changed the title
+ remove deprecated `false` type in `getMetaData()` method + remove unnecessary @inheritdoc annotation
+ clarify deprecation removal of `false` type for `CacheInterface::getMetaData()`
yassinedoghri
force-pushed
the
fix/cache-interface-2
branch
from
622dd8b to
ff35267
Compare
| * @param mixed $value | ||
| */ | ||
| public function save(string $key, $value, int $ttl = 60) | ||
| public function save(string $key, $value, int $ttl = 60): bool |
Member
There was a problem hiding this comment.
I think you can natively type the mixed param without breaking LSP, right?
Contributor
Author
There was a problem hiding this comment.
Good catch, the type is actually bool, so I removed the docs declaration.
Member
There was a problem hiding this comment.
Sorry, what I meant was you can write mixed $value in the method signature.
Contributor
Author
There was a problem hiding this comment.
Oh, my bad! I was too quick 😅
Yes, just tried it, you can natively type the mixed param without breaking LSP.
That being said, should I not just change the $value signature in the CacheInterface as well? (so it's explicit)
Member
There was a problem hiding this comment.
Yes, pls replicate the change to other handlers and the interface itself.
yassinedoghri
force-pushed
the
fix/cache-interface-2
branch
from
fba94bc to
2df6524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the previous PR (#9809), this is the second part of the CacheInterface refactor.
This PR adds native return types to all CacheInterface methods and updates the user guides accordingly.
Checklist: