-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat: Spring Boot 4 support #4838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
TODO: Fix Autoconfiguration for RegistrationClient
|
@SteKoe would it be possible to publish this 4.0.0-M1? |
We still need to fix some tests. |
| <dependency> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter</artifactId> | ||
| <artifactId>spring-boot-starter-classic</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be changed, you really don't want to the client to pull in all the classic starters. Given that spring-webvmc is a dependency, and that the resttemplate is used, wouldn't spring-boot-starter-webmvc and spring-boot-starter-restclient pull in all the required things?
|
Hi folks. I was about to start a PR for this very effort now that spring boot 4 is GA, but I think this branch is further ahead that It's better to help to get this PR over the finish line and cut a milestone. Is there a timeline for getting this PR in shippable shape or would you like any other contributions to help get it there? |
No description provided.