Add build failure notification support #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the event of a failure. Since Parallel-Ant can be executing two or more targets at the same time, the ParallelExecutor was updated to handle potentially multiple BuildExceptions being thrown (via the new notifiyException callback). In the case there are multiple BuildExceptions reported at the same time, these are collected into a single string and a single new BuildException is thrown with this content. Additionally, the ParallelExecutor will signal the executor to stop upon any BuildException occurring to stop the build as soon as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for collecting (potentially) multiple BuildExceptions that can occur when executing multiple targets at once, combining them into a single exception string and throwing a single BuildException to Ant. This provides each failure's stacktrace in a newline delimited format for the user to investigate.
Additionally, if a BuildException does occur the executor is signaled to shutdown, stopping the build once the remaining targets that are currently running have completed.