Refactor code and cleanup #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W2Wizard
suggested changes
May 30, 2023
Contributor
W2Wizard
left a comment
W2Wizard
left a comment
There was a problem hiding this comment.
Yes I did this now after months right during my internship.
Only ask you to actually triple check if this works.
Comment on lines
+52
to
+55
|
|
||
| export function random() { | ||
| return Math.random() < Config.randomEvalChance / 100; | ||
| } |
Contributor
There was a problem hiding this comment.
Why ? The whole idea is to separate all potential checks into their own files to avoid cluttering them into a giant file like this.
Contributor
There was a problem hiding this comment.
Also please start using docs.
Contributor
Author
There was a problem hiding this comment.
I'll add comments
And I moved it to a single file because they're all part of the same Checks namespace
Otherwise you have 2 files with < 5 LOC in it
Now we have one file with 55 lines
Much cleaner
Contributor
Author
|
Stop changing my messages |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored and simplified some parts of the bot, mainly in regards to the database wrapper to avoid more bloat. #Joptimized
Also I need to learn how to make PR's since I am a junior dev.