feat: add nodeselector annotation to limit LB pool members #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the possibility to limit a LoadBalancer created using a Service to only a specific set of nodes.
Notes for reviewers:
If you come up with a better way to check the LB actually switched to the intended pool member number please let me know. It's a bit ugly having to fetch the members from the API directly. However, I can't verify it using the service alone because while the LoadBalancer members are adjusting, no change is made to the service. This in itself might be something we need to consider, however IIRC we can't know this at the moment due to missing information in the API.