In place DocDB version upgrading #143
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
Recently, we wanted to upgrade DocDB version 4 to 5 using terraform and AWS in-place major version upgrade (MVU), but were unable to due to following error: (see references)
The issue occurs because paramter groups need a unique name and are tied to a specific version(see image ref 1). If you want to make an MVU you need to 1: Create a new paramter group with a unique name and your specific cluster version, because you cannot upgrade or reuse old paramter groups 2: Apply new version + supply new parameter group.
Currently, it's impossible to upgrade to a new docdb version using this module. This module always creates a parameter group with the same name as the cluster. If you want to upgrade, the cluster name has to stay the same. Therefor, terraform will try to create a parameter group for the new version but will fail to do so since a parameter group with that name already exists. You cannot have 2 parameter groups with the same name even if they are tied to different versions (see image ref 2). Therefor, a way to create unique names for each version is required.
How does MVU work with this proposed change?
Why not change the name of the cluster?
Is this a breaking change for already existing infrastructure?
No, but it will need a reboot to apply the changes. (see image ref 4 & 5)
image ref
Image Ref 1:

Image Ref 2:

Image Ref 3:

Image Ref 4:

Image Ref 5:

references
#116