Skip to content

Conversation

@jwcesign
Copy link

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix: re-enqueue not too offen if error happened

Which issue(s) this PR fixes:

Fixes #none

Special notes for your reviewer:

fix: re-enqueue not too offen if error happened

Does this PR introduce a user-facing change?


@gitautomator
Copy link
Contributor

gitautomator bot commented Sep 12, 2025

Thanks to your contribution, the maintainers will review it as soon as they can!

@gitautomator
Copy link
Contributor

gitautomator bot commented Sep 12, 2025

The release note is either empty or incomplete, please consider: Fix the issue where re-enqueue happens too frequently when an error occurs.

@gitautomator gitautomator bot added the bug Something isn't working label Sep 12, 2025
@Vacant2333 Vacant2333 requested a review from Copilot September 12, 2025 04:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes error handling in the nodeclass status controller to prevent excessive re-queuing when errors occur. The main purpose is to add a 30-second delay before retrying when API calls fail, making the system more resilient to transient errors.

  • Adds RequeueAfter delays to error handling in VSwitch, SecurityGroup, and Image status reconcilers
  • Simplifies error handling in the main controller to propagate errors while still respecting requeue timing
  • Maintains existing requeue intervals for successful operations

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
pkg/controllers/nodeclass/status/vswitch.go Adds 30-second requeue delay when VSwitch listing fails
pkg/controllers/nodeclass/status/securitygroup.go Adds 30-second requeue delay when SecurityGroup listing fails
pkg/controllers/nodeclass/status/image.go Adds 30-second requeue delay when Image listing fails
pkg/controllers/nodeclass/status/controller.go Simplifies error handling to propagate errors with requeue timing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: jwcesign <jwcesign@cloudpilot.ai>
@jwcesign jwcesign merged commit 4bc6bc9 into cloudpilot-ai:release-0.1 Sep 12, 2025
2 checks passed
@jwcesign
Copy link
Author

/cherry-pick release-0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants