Skip to content

Conversation

@lhhyung
Copy link
Member

@lhhyung lhhyung commented Jun 5, 2025

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

Fix typo

Known issue

@lhhyung lhhyung requested a review from Copilot June 5, 2025 08:47
@lhhyung lhhyung self-assigned this Jun 5, 2025
@lhhyung lhhyung added enhancement New feature or request pass/signedoff labels Jun 5, 2025
@lhhyung lhhyung merged commit a6e4b0b into cloudforet-io:master Jun 5, 2025
0 of 2 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the import statement in azure_cost_mgmt_connector.py to include the Generator type from the typing module, addressing a typo.

  • Updates the typing import to include Generator
  • Corrects the import statement in the azure_cost_mgmt_connector.py file

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

⚠️ @lhhyung the signed-off-by was not found in the following 3 commits:

  • 44e9e38: fix: fix typo
  • e5d757d: Merge remote-tracking branch 'origin/master'
  • c3c3efa: Merge branch 'cloudforet-io:master' into master

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 5, 2025

⚠️ @lhhyung the signed-off-by was not found in the following 3 commits:

  • 44e9e38: fix: fix typo
  • e5d757d: Merge remote-tracking branch 'origin/master'
  • c3c3efa: Merge branch 'cloudforet-io:master' into master

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request pass/signedoff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant