-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[C3] Support template substitution in wrangler config files #11520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vicb
wants to merge
3
commits into
main
Choose a base branch
from
vicb/c3-substitution
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+352
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c320e96 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
fd037c7 to
13f666c
Compare
13f666c to
83e8243
Compare
83e8243 to
c320e96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds template substitution for the wrangler config files.
<WORKER_NAME>is replaced with the worker name (from the project).<COMPATIBILITY_DATE>is replaced with the latest workerd dateThis in in addition to how
<TBD>is currently replaced by a context depend value (could be either the worker name or the compatibility date)Notes:
<WORKER_NAME>is needed to unblock Open Next (in a follow up PR)<COMPATIBILITY_DATE>is not currently used but will be used to make substitution clearer, see "Future work" belowFor
.json/.jsonconly the string values are considered.For
.tomlit uses a simple string replace - which should be ok if we use uncommon key format.Note / Future work:
We currently use this pattern for wrangler config / package.json:
{ "name": "<TBD>", "main": "src/entry.py", "compatibility_date": "<TBD>", "compatibility_flags": ["python_workers"], "observability": { "enabled": true, }, }IMO we should replace that with the mechanism of this PR for clarity, i.e.
{ "name": "<WORKER_NAME>", "main": "src/entry.py", "compatibility_date": "<COMPATIBILITY_DATE>", "compatibility_flags": ["python_workers"], "observability": { "enabled": true, }, }(We should keep the current logic for backward compatibility but update it and the templates)