Reduce node_modules size
#11464
Reduce node_modules size
#11464
Conversation
|
petebacondarwin
left a comment
petebacondarwin
left a comment
There was a problem hiding this comment.
Looks like an actual failure in the wrangler build: https://github.com/cloudflare/workers-sdk/actions/runs/19769107361/job/56649060509?pr=11464#step:6:548
| # CAUTION: Most usage of @cloudflare/vitest-pool-workers in this mono repo should use workspace:* instead of this catalog version | ||
| # However, some packages (pages-shared, workers-shared, etc...) need to be tested using vitest-pool-workers but are themselves | ||
| # ultimately included in vitest-pool-workers (through Wrangler), causing a circular dependency. |
There was a problem hiding this comment.
Thank you for this comment!
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
| // Get a new stub since we've just aborted the durable object | ||
| const newStub = env.ENGINE.get(env.ENGINE.idFromName("MOCK-INSTANCE-ID")); | ||
|
|
||
| await newStub.receiveEvent({ |
There was a problem hiding this comment.
Are these other changes meant to be in this PR?
There was a problem hiding this comment.
Yes, they're to adapt to the vitest-pool-workers update for workflows-shared
penalosa
force-pushed
the
penalosa/dep-size
branch
from
da83244 to
7965855
Compare
penalosa
force-pushed
the
penalosa/dep-size
branch
from
7965855 to
0702c18
Compare
3 participants
Cut the
node_modulessize for a fresh install of workers-sdk by 400MB from 2.3G to 1.9G. This should speed up CI install times, but there's definitely more work to do. This is a combination of changes to deps and runningpnpm dedupe