Skip to content

Conversation

@petebacondarwin
Copy link
Contributor

A collection of small changes:

  • ensure that we don't bump TypeScript accidentally - 5.9.x appears to cause typings problems with some of our packages
  • allow PWD to be passed into turbo jobs
  • simplify the workers-utils package's vitest config
  • change C3 builds so that it can import the ESM modules from workers-utils

  • Tests
    • Tests included
    • Tests not necessary because: refactoring covered by current tests
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal refactoring
  • Wrangler V3 Backport
    • Wrangler PR: TBD
    • Not necessary because:

@petebacondarwin petebacondarwin requested a review from a team as a code owner November 25, 2025 17:55
@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2025

⚠️ No Changeset found

Latest commit: 2b32c10

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Nov 25, 2025
@petebacondarwin petebacondarwin added the skip-v3-pr Skip validation of presence of a v3 backport PR label Nov 25, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 25, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11414

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11414

miniflare

npm i https://pkg.pr.new/miniflare@11414

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11414

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11414

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11414

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11414

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11414

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11414

wrangler

npm i https://pkg.pr.new/wrangler@11414

commit: 2b32c10

@petebacondarwin petebacondarwin marked this pull request as ready for review December 5, 2025 07:24
# rimraf@6 requires node 20 or >=22
rimraf: "^6.0.1"
typescript: "^5.8.3"
typescript: "5.8.x"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a difference between this and ~5.8.3?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes there ~5.8.3 does not consider 5.8.0, 5.8.1, and 5.8.2.
I don't really think it's a problem.
I have a slight pref for ~5.8.3

setupFiles: path.resolve(__dirname, "tests/vitest.setup.ts"),
globalSetup: path.resolve(__dirname, "tests/vitest.global.ts"),
reporters: ["default"],
globals: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I tried that across the repo and it failed (I have a closed PR)

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changeset-required skip-v3-pr Skip validation of presence of a v3 backport PR

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

3 participants