-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Miscellaneous improvements and refactorings #11414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
ae5fdf9 to
bd0edd6
Compare
8011b0c to
bd0edd6
Compare
bd0edd6 to
90ab9d6
Compare
90ab9d6 to
e30778b
Compare
e30778b to
2b32c10
Compare
| # rimraf@6 requires node 20 or >=22 | ||
| rimraf: "^6.0.1" | ||
| typescript: "^5.8.3" | ||
| typescript: "5.8.x" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a difference between this and ~5.8.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes there ~5.8.3 does not consider 5.8.0, 5.8.1, and 5.8.2.
I don't really think it's a problem.
I have a slight pref for ~5.8.3
| setupFiles: path.resolve(__dirname, "tests/vitest.setup.ts"), | ||
| globalSetup: path.resolve(__dirname, "tests/vitest.global.ts"), | ||
| reporters: ["default"], | ||
| globals: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: I tried that across the repo and it failed (I have a closed PR)
A collection of small changes: