Skip to content

ci: concurrent tests #11379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vicb wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ci: concurrent tests #11379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .github/workflows/test-and-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,6 @@ jobs:

- name: Install Dependencies
uses: ./.github/actions/install-dependencies
with:
turbo-api: ${{ secrets.TURBO_API }}
turbo-team: ${{ secrets.TURBO_TEAM }}
turbo-token: ${{ secrets.TURBO_TOKEN }}
turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}

- name: Check the changesets
run: node -r esbuild-register tools/deployments/validate-changesets.ts
Expand Down Expand Up @@ -133,7 +128,7 @@ jobs:
# We are running the package tests first be able to get early feedback on changes.
# There is no point in running the fixtures if a package is broken.
if: steps.changes.outputs.everything_but_markdown == 'true'
run: pnpm run test:ci --log-order=stream --concurrency=1 --filter="./packages/*"
run: pnpm run test:ci --log-order=stream --filter="./packages/*"
env:
NODE_OPTIONS: "--max_old_space_size=8192"
WRANGLER_LOG_PATH: ${{ runner.temp }}/wrangler-debug-logs/
Expand All @@ -154,7 +149,7 @@ jobs:
- name: Run tests (fixtures)
if: steps.changes.outputs.everything_but_markdown == 'true'
# Browser rendering is disabled on Ubuntu because of https://pptr.dev/troubleshooting#issues-with-apparmor-on-ubuntu
run: pnpm run test:ci --concurrency 1 --log-order=stream --filter="./fixtures/*" ${{ matrix.os == 'ubuntu-latest' && '--filter="!./fixtures/browser-rendering"' || '' }}
run: pnpm run test:ci --log-order=stream --filter="./fixtures/*" ${{ matrix.os == 'ubuntu-latest' && '--filter="!./fixtures/browser-rendering"' || '' }}
env:
NODE_OPTIONS: "--max_old_space_size=8192"
WRANGLER_LOG_PATH: ${{ runner.temp }}/wrangler-debug-logs/
Expand Down Expand Up @@ -182,7 +177,6 @@ jobs:
matrix:
include:
- { node_version: 20, description: "Node 20" }
- { node_version: 24, description: "Node 24" }

steps:
- name: Checkout Repo
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"fix": "dotenv -- turbo check:lint -- --fix && pnpm run prettify",
"prettify": "prettier . --write --ignore-unknown",
"test": "dotenv -- turbo test",
"test:ci": "dotenv -- turbo test:ci",
"test:ci": "dotenv -- turbo test:ci --no-cache",
"test:e2e": "dotenv -- turbo test:e2e",
"test:e2e:c3": "dotenv -- node -r esbuild-register packages/create-cloudflare/scripts/e2e/run-tests.ts",
"test:e2e:wrangler": "dotenv -- node -r esbuild-register tools/e2e/runIndividualE2EFiles.ts",
Expand Down
3 changes: 2 additions & 1 deletion packages/wrangler/turbo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@
},
"test:ci": {
"dependsOn": ["build"],
"env": ["VITEST", "NODE_DEBUG", "MINIFLARE_WORKERD_PATH"]
"env": ["VITEST", "NODE_DEBUG", "MINIFLARE_WORKERD_PATH"],
"cache": false
},
"test:e2e": {
"inputs": ["e2e/**"],
Expand Down
Loading