Add hostmetrics/process heartbeat #549
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poil
requested review from
BzSpi,
JMHAUTBOIS-Claranet,
Shr3ps,
cvauvarin,
haedri,
pdecat and
tchernomax
as code owners
haedri
reviewed
Feb 16, 2024
Contributor
haedri
left a comment
haedri
left a comment
There was a problem hiding this comment.
This module should be named otel-collector_hostmetrics-process, no ?
| By default, only `critical` rule is enabled. This allows the detector to check if the service has, at least, | ||
| one process running. | ||
|
|
||
| Optionally, this is possible to enable `warning` rule to check if the service has a minimal amount of process |
Contributor
There was a problem hiding this comment.
Hum what does this refer to ? I can't see anything resembling that in the heartbeat....
Poil
commented
Jul 24, 2024
| default = {} | ||
| } | ||
|
|
||
| variable "heartbeat_aggregation_function" { |
Contributor
Author
There was a problem hiding this comment.
'process.command_line' + 'hostname' ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use hostmetrics (and stop using smartagent)